[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.14] tools: Fix pkg-config file for libxenstore
- To: Jürgen Groß <jgross@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 22 Mar 2021 16:35:47 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=61rUhLM+UZf/K/gBDqfpryxPK0ZOcihIw7fPC067+bY=; b=hqwb3JKlqk4uKKRwzxYNPIUq4kW64MOnxvpip/I4O4+lIYHaYcVb24DxEXniITZNnCtCzEla7I+jLjQlEtyjFh+6hi1h0sSCKYRdNH9WCU7lyrdswrSg2aCUYeV37+gFaHoWzbPoCSZbFOqzrrPSUfaQl5oQ+J2gVZ6yLBJ+JV0q24T1TcZNWd4ADfe7kqBseaSUOb109Ykrg2/un2zgDW9K8tjZtCR80Q5AM2iA6iusu1lTTY8kCn3+hZ9jFvDtY4L2QNWeBscdanp/SBentAHumovq74yjjom6LKJEMvbg1bAKagBRk39f8H2av7IVReOqhORcdjEiX7b5pxfbSA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hSmFyJDOMt3mlGqJagnk2CpV+hiUdBvYFThXGtECp6tMK+eUC7ZaOqCLo2W4XzIudWD9NM6WxWdXAQb8WBIcf0oSRlkJm6WhiV1R6Z8pFXCXkidpQfbU2H+XWz6REGS4oDxLjFs9DjZ/Ck30Kt0rYC7zFRYCiIlSEg+5G8rwwPMlOwCffn4Dn0voWA68wRi5JlUyA0sDQ+EbEnsWa69HYHqtHwfJIKvvZNI1INESBAx1aHKteCisNgO9f48LL9A6Ufsr4owAiloCrT7nK6+Tf1NoHBmzzmUEKPd6PYzLRYgmkDd3xlhV738Y5/b+KES6OR+P48KcARAxm2L4P9nkbg==
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>
- Delivery-date: Mon, 22 Mar 2021 16:35:58 +0000
- Ironport-hdrordr: A9a23:2zQ3eaPnaeNt4sBcT0jw55DYdL4zR+YMi2QD/3taDTRIb82VkN 2vlvwH1RnyzA0cQm0khMroAsa9aFvm39pQ7ZMKNbmvGDPntmyhMZ144eLZrwHIMxbVstRQ3a IIScVDIfXtEFl3itv76gGkE9AmhOKK6rysmP229RZQZCtBApsQiztRIACdD0FwWU1iDZ02CJ KT6qN81kWdUF4Qadm2AWRAYvPKoMfFmImjTRkNARMm7wfmt0LV1JfRFR+E0hACFw5e2LtKyx m5ryXVxIWG98u6xBjVynPJ4/1t9ufJ59NfCKW3+7AoAxr2jALAXvUGZ5Sju3QPrPir+BIWlr D30m0dFuBSz1+UQW2vuxvq3GDboUUTwlvv00WRj3emgeGRfkNCN+N7iYhUcgTU5iMb1bkWus I7vBPti7NtARzNhyj77dTTPisa8XacmnY+jfUVy0VWTIp2Us4gkaUk4EhXHJ0cdRiKirwPLe 8GNrC42N9ra1+AK1jWsm5zqebcJUgbL1OtR0gPvdGtyD5GnHx15Ftw/r1vol4wsL06UJVK/O LCL+BBk6xPVNYfaeZHCP4GWtbfMB2AfTv8dEapZXj3HqAOPHzA77bx/bUO/emvPLgF1oE7lp jtWE5R3FRCNH7GOImr5tlm4xrNSGKyUXDG0cdF/aV0vbX6Wf7CLTCDYEpGqbrhn9wvRungH9 qjMpNfBPHuaUH0H5xS4gH4U55ObVEDTcwuvMohUV7mmLOLFqTa8sjgNNrDLrvkFjgpHknlBG EYYTT1LMJcqm+xXHvVhwXQRmPNdkTz8YkYKtmZw8EjjKw2cqFcuAkcjlq0ouuRLydZj6AwdE xiZJPr+5nL4FWezCLt1SFEKxBdBkFa7PHLSHVRvzIHNEvybPIms9WbcmZC4WufKnZEPofrOT 8ag24y1bO8LpSWyyxnIcmgKHimg3wao2/PaJsAhKuZ54PAdokjBpgrHIx9fD+7WSBdqEJPki NueQUETkjQGnfFkqO+lqEZA+nZap1bmwekIcldrFrFrkWCrcQTRn8WNgTeEvK/sEILfX55l1 dx+6gQjP6rgjC0M1Yyh+w+LRlxcmiNOalHCw6EfY1QvbjudGhLPCC3rA3fryt2Vnvh9k0UiG CkCSGPY/nEDmBQvW1i3r/w/El5cXiceExMeml32LcNZ1juizJW66umd6Cz22yeZh85zuYRPC rsTBESLgltrurHnyK9qXKnLzEL158uNuvSAPAfaLnVwGqqM5DNv7oBBeVo8JFsM83OvucHXf mEQRKcKCr1BooSqkqoj0dgHBMxjnYqkfnlgkK4qEe52WMyGvrULhBNQaoBL9SV8mjjQLKp3f xC/KUIlNr1Fl+0TNiMjZzzRXpkDDj4pGatVeEmqZxOp8sJxfNONqiedQGN7W1N2RU1Edz9m0 wfSplq+bypAP4aQ+UiPwZiumcznNuBLEEXohX7L+83c1YqlWLaNbqyksz1gItqJk2Kvw3rP1 aDtwVb4vfeRiOGvIRqQZ4YECBzaEIm7m5l8/7HX4rMCB+yf+UG2FahKHeyfPt8T6eCcI9g4y pS0pWtn+WNcTD/1x2VlTxnIrhW+2LiePiMOmu3aKd12u3/H0+NjKus6NOyizmyaQLTUTVnua R1MWoKbspCjTE+ipYQySbacN2vnn4Y
- Ironport-sdr: bcLKy1VG/wKD9EBA/RIzeIgPZ5Yorn9f0tKNPiOGj5kyCWflWCLrwr2c7tcmeGRoo0L/pS9jNg 0BS0V1lw8JwhJb/gfc7yXkQeF87K3YsCRiJ3ps5RjP8XZAswYqZyz0IK+6aY4QEB/Oon5mF3Ow pzvyqA5OuJsLL+sl484Fnbs8hQ2iGwovBriy1rGlnlM1RG25Ir5twQNwpjfEfobYb9bC18IlqM FPYKqioQcxuBsW9jdRAyphKTwEpwSBCUH2RbHWN+uj0v52WfzxneB83jwfRM04Mll0vCcF5RbO dko=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22/03/2021 16:32, Jürgen Groß wrote:
> On 22.03.21 17:20, Andrew Cooper wrote:
>> There is no dependency on libxenctrl.
>>
>> Fixes: 1b008e99 ("tools: provide pkg-config file for libxenstore")
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> ---
>> CC: Ian Jackson <iwj@xxxxxxxxxxxxxx>
>> CC: Wei Liu <wl@xxxxxxx>
>> CC: Juergen Gross <jgross@xxxxxxxx>
>> CC: Jan Beulich <JBeulich@xxxxxxxx>
>>
>> This has been fixed in Xen 4.15 by the uselibs.mk logic, but 4.14 and
>> older
>> cause everything linking against libxenstore to also try linking against
>> libxenctrl. It also causes RPM to create unexpected dependencies
>> between
>> subpackages, which is a problem when trying to separate the stable and
>> unstable libs.
>> ---
>> tools/xenstore/xenstore.pc.in | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/xenstore/xenstore.pc.in
>> b/tools/xenstore/xenstore.pc.in
>> index 2f64a6b824..98c3f1ab39 100644
>> --- a/tools/xenstore/xenstore.pc.in
>> +++ b/tools/xenstore/xenstore.pc.in
>> @@ -8,4 +8,4 @@ Version: @@version@@
>> Cflags: -I${includedir} @@cflagslocal@@
>> Libs: @@libsflag@@${libdir} -lxenstore
>> Libs.private: -ldl
>> -Requires.private: xenevtchn,xencontrol,xengnttab,xentoolcore
>> +Requires.private: xenevtchn,xengnttab,xentoolcore
>
> Any reason you are keeping xenevtchn and xengnttab?
Oh - good point. I misread uselibs. Its only toolcore who's dependency
remains in 4.15.
I'll send out a v2.
~Andrew
|
