[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.15] arm: replace typeof() with __typeof__()
- To: Elliott Mitchell <ehem+xen@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 9 Mar 2021 21:27:34 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EHAWXWQeFMG1dZV+TkKBpIvZ2X4MziZTej5Jb9/tD8s=; b=UfhxqAeYVilgQXb5JMTDAyiTOczlVbQHiG+37nSR/OUZCvKFQhJYbn0IhyAR7XGFZL1lEdZEKe5A7xR0LoDyLR7f00gqkilw+Pk7Q06pQXDUhUbAoA8LwCX77Rfk3GKc56phzROox/TEJ+gY5tJuh5yP/SjolhiN7jwCKoEdbuQSCguDV9kW2hENkMxUVJctlszvWUu49+Qie0lhS5VcRhA/TUJo+ClBK5+xIIbYY7zi1n0j1gvrS5uCuNlDQbRpHkIEdVApiysKSJl1fLWdrUx9ZOSqcoMgHHlCZP5qA2Pq4Z4iRdeT4Mwg8w/aCHI1TSh30vao+ODgfk1phP3QiQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c7f1fAvR13JwzgkE1fLDKkFOzLW4Lhy5MC5cGyCeYSDxXtJDMyDE6tmoEa4lLF4aiqyaWD5PBQk5CZ5MU3yWcQHjFh6dO5l9DCmWtfDKm8jqDQUmgLUL3v6/+W+AoptLrU31e0cub3cNdY5IRSFfVTrk2olISANsGDPzB8P6t4zP5jxftradSfCEKTJdClTJ+dJXAADDfjaMrEqfd0tEX8LcfSzyIhz9gZudq12HT/JaLvHFsiYlL3wejv2287fJTfz+/mMWPwBI6HH2i/9hsNHfOkyfXM39ahIJqez8GzMkEweeVJA+RtOb/DsMm8XHkBSzVvuSdt+rt6zVidQgqw==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Tue, 09 Mar 2021 21:28:25 +0000
- Ironport-sdr: OzOu2NJ0T+GUbtZW4pNe+3ItqPiRQV8pwhTM+xe+FognLQZ3m9ApM/TutgouqFP50let+z0j2c JopbjPc0ihqZHSL8gDUG3drir4kzoyXznJK1xjb3L3ssYgY4jTXqbHWeaSjOQMzom6Bb7zS/Bs X8obeBVYsES6Bnl3B4rcOeHZggsQ1lC4jb91NyBHzE0aTBXsX6u28CBBq/s/rEGQSOFyPO7dMu mBqAzzTqAsXEok+sE0O1uJvCIlcbsZycV363HlRRFno+nbEm2nd/yQJda/KCgCF6lvpx8ygM4F gMM=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08/03/2021 13:36, Elliott Mitchell wrote:
> typeof() is available in Xen's build environment, which uses Xen's
> compiler. As these headers are public, they need strict standards
> conformance. Only __typeof__() is officially standardized.
>
> A compiler in standards conformance mode should report:
>
> warning: implicit declaration of function 'typeof' is invalid in C99
> [-Wimplicit-function-declaration]
>
> (this has been observed with FreeBSD's kernel build environment)
>
> Based-on-patch-by: Julien Grall <julien@xxxxxxx>, Sun Oct 4 20:33:04 2015
> +0100
> Signed-off-by: Elliott Mitchell <ehem+xen@xxxxxxx>
s!arm!xen/public! in the subject seeing as two thirds of the
modifications are in non-ARM headers.
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
This wants backporting as a build fix, so should be considered for 4.15
at this point.
I wonder why our header checks don't pick this up. Do we need to throw
a -pedantic around?
|
