[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 2/3] xen/events: don't unmask an event channel when an eoi is pending
- To: Juergen Gross <jgross@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, ross.lagerwall@xxxxxxxxxx
- From: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
- Date: Mon, 8 Mar 2021 15:33:33 -0500
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sfh4bTAv0pzzVgRm13LxdL0UG9lCgW8MA+UnVFVa5II=; b=cCb9APGjKrVkBvJzhoTJeUQX5X9iqJ1voTS1NBsmzl4hA5zFShgEyCuCMHlEEw3k3XE3UnWyn3dRQEjX6mGpP5NxefEYEYjs7KNylVDRuWIH1YCjEz3ECdCJylze95kwTo5X33bckaW4qht2I9yrbhqMqUYjMQ87ojQvC8dLfxfR118uGO1ZV1SYHoYnoMOiqG3T84U3Qeue5ylNxCIFW8B6J+NK7b0VGuaXprD/4+lyBBd0UZiNVKyJsHYVdUG/7b7TzpyPrW4ZedInHoN2gE+yr1Q5PbH6yMzsVnPfF7ZVnTNIbhnwD9OS8M5KcDNvbOTtm9OWWDp37VSPmMyhWA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g+0BiV0H2HQJOgOK8QmRlz5ud817vLtBPhMN4Jszh1nBDmj9kPW3eA3EzVcOIGuGdlAaFgsZ1tHPIPY4dKioX+2LEveDwHb9C42YfnAvSYZcZH9YKW7B6oT1juRkuYucrGDr+DM3jtTzt6y3t9c0z/kabHCVzJPkZF1/kRWm+aJz2rqNzPnXJMPML89aVhF6qBi/Ozy6eHWrdqXhzIOGiGN0947Qk31PSWJzkx2vysnTo8RR8XCP7q9sdptqZMEWLHSIZrRf0vMZWNgxy77rBNf6RK0Vjg0R4Q9XlnSeMn4Z2ExE9BUT+8lMwnplM0n3PCZW0jNQDCmW8rFJmYztXA==
- Authentication-results: amazon.com; dkim=none (message not signed) header.d=none;amazon.com; dmarc=none action=none header.from=oracle.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, stable@xxxxxxxxxxxxxxx, Julien Grall <julien@xxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>
- Delivery-date: Mon, 08 Mar 2021 20:33:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 3/6/21 11:18 AM, Juergen Gross wrote:
> An event channel should be kept masked when an eoi is pending for it.
> When being migrated to another cpu it might be unmasked, though.
>
> In order to avoid this keep three different flags for each event channel
> to be able to distinguish "normal" masking/unmasking from eoi related
> masking/unmasking and temporary masking. The event channel should only
> be able to generate an interrupt if all flags are cleared.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: 54c9de89895e0a36047 ("xen/events: add a new late EOI evtchn framework")
> Reported-by: Julien Grall <julien@xxxxxxx>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
> ---
> V2:
> - introduce a lock around masking/unmasking
> - merge patch 3 into this one (Jan Beulich)
> V4:
> - don't set eoi masking flag in lateeoi_mask_ack_dynirq()
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
Ross, are you planning to test this?
-boris
|
