[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-4.15] xen: Bump the minimum version of GCC supported to 4.9 (5.1 on arm64)


  • To: Julien Grall <julien@xxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Sun, 7 Mar 2021 11:57:40 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M/kcEvGz1tQFHCcP3t01GSZz7P2SJD1K3ySFGeFsoys=; b=MR27zqym5gN3mtm9PvbUhKloBtuNPXvwFlbWRgJUf4Q9PoYchUzeVjMc30nZGjpdlZIpjcW05U38CtcfavgjJgIPaBOzzuF/V9W0RSkupOtVDSrrFAayw4+13JQjXa3qLxmskboq9kZ5wnj0+xuwSV/yee06hs02sWgdyO7Sl57KCkiu8U7eAHaYmGY+WZSSPFhYWq8QTly/m825xSDrNSIF78TaNr92cQjo/WP3gk/C5zHi8AKZujLbxz63FY8Lb6nJp/75VBLApD8eTmFjfC0r9NCJWeDpGHzBc550c0G/lM3CZxZRvD+9ysB2m6GNTrQWalkGOD5LgNRip67sGA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aMrwM5Er08/sAsGJNCMvCji8rQ7tOyT8NYyxNZ1sQhB7PxO+XtO1ld5JvwZxhvTgw/TpRUAUa9YKPi76tAkY1TMcxQs0IzzNm8dvtfKAAocf2JOUzDtRC1oGia8CmNR6X06d4kIObsWJM/XokKsfULKnAvw6WnLuzxUpdbze7lELJ26LgHQ+6R5t1ht5XDtdz4GgUnrfqWoECKWyGE/1+suSxXO/2k+7mb5AaJmxXreXDbC6JMM/vK5f12jvd3UWXeNqQ8RdlddJZmgAobh0XVQNcx0OmcInZzAk09ZOV9awGJwUE5mJDYpxGKg5RtM2rc2i5lTzvBux4IIKAgg/eQ==
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Sun, 07 Mar 2021 10:58:12 +0000
  • Ironport-sdr: dKDLkF2Mzv5teOYrtc3oFCYIpYxSH89BvwqjOIfH371FWqD6S2zUDAYoOMfzpvCN4XO6ndeIWh mQymJSYDJ48iXZB2A0UvNMzOy6mQ23hmRgxx/I2gfcQWAdWNiVp5EVyQ06ITlQTKBDQHV51EqE TBISRJOpCw/xljy5Gu4xkQBkB9Gri/MM3C32eu+MDlXcUeK9fAY5MYyyh+DkglQP4NLZY4uNZF qOMHAhfidpnDT7Uk6o0UW5puDoA0D66WdPzmyAis0Bfiatr3CKbNbveb6u1cdpTJ9b4Otm/MmD hck=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Sat, Mar 06, 2021 at 09:41:48PM +0000, Julien Grall wrote:
> From: Julien Grall <jgrall@xxxxxxxxxx>
> 
> Compilers older than 4.8 have known codegen issues which can lead to
> silent miscompilation:
> 
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145
> 
> Furthermore, pre-4.9 GCC have known bugs (including things like
> internal compiler errors on Arm) which would require workaround (I
> haven't checked if we have any in Xen).
> 
> The minimum version of GCC to build the hypervisor is now raised to 4.9.

The README entry doesn't differentiate between tools and hypervisor
GCC version, can the bug above also manifest in toolstack code?

I don't think it makes much sense to have diverging requirements for
tools vs hypervisor builds, but if the bug(s) can also manifest in
toolstack code we might want to add a GCC version check to
tools/configure.ac.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.