[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.15] tools/libxendevicemodel: Strip __XEN_TOOLS__ header guard
- To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 4 Mar 2021 22:24:18 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HHGO3gHLGY48Ws0T1aa+wPfhzSC7Xj3ox0pREaBXfuU=; b=aQ5fG7r3Zu+2nOTlxlGlukPCrDuTvn5Xp262FWNsvYhb5ZIka29kTjvYtYiHs4c62sKDir66l27us7d4VDhXgV0Phyi+HyR51kCyHUK4udBQqb6qj2Dq81eKk888g/v5GMKoznHnydlmMfiax0dJWdFRTLx8SEP9wLZ42dO+LD7npHRYymP1noXMmSpI04Ih97RqhKWt9ZMKY4feyz9APWmRMKKpzxIbzRUONwtguB6lGpx9qhahpSyZX88uY8V4C9tbZWbAj9z1weT4AicG+pvA4CA+qJq2QMkSRDxhX1VmcjPpgqhso0UGBMUGB3+4Pex5jOIY6JTgnnMFHZqXyA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W6CsKd/pMptu2NE/BjHX6rZKrFhAdE10wzjDxukIUziFNR1DepdOmYNyo8jvERN6gS0UeW4/TAa+nuNs1l/DJ72fG/7TSVxKYiZ0d4YczQUTEp4C7h0eV9yw0Xuw+TsawLSkq7cMwsOKMNeWs6CH74kZHYb8u10ayla62Kcw2phhThNLZHKrZKlZG767o6Uhf2JM/DWVHRYzQDHk56ftJfIrvaOF2FddUEuzM25PiaJTnod3ehWZrM+nIqbcFz+ihDs0VzKq3GFPt1DsDN9J0mmO7/25zA6w0qAYYCKBR8sccsJsklLO6ygYK5iB5R3ZwbNtEGp9Sp71TH3cszxm5g==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Thu, 04 Mar 2021 22:25:01 +0000
- Ironport-sdr: DUuVPUC2wmOQBNbzrDpUn/DeAWuw8hajHjLfbEl3FRgLWtP1HBmN3RwgvfbbuC4Cv7HO+599aR S/SaxPmZ1xBALdySA68Bzxilq4n+29kR5aO10446fy/QjISAlZE/e1goiU1ETmBMp1CKIAGLMc 0KXBz3nsnD3BfSTqKXOKXI96Ih/YPZjR4GG+eX/cQxwIIEBO48tGLkDEN1e3yfyV+CQ1GI9Pjn Cp1Tfs4Z03Ie/4Zga7qd7XKvZKvWa6aQr83WkFOPJYCpQsAagHevnfPOUlgFeKpsfaCBYrINfR 3No=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04/03/2021 13:03, Andrew Cooper wrote:
> This is inappropriate for the header file of a standalone library with stable
> API and ABI.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Ian Jackson <iwj@xxxxxxxxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
>
> Discovered when trying to actually remove the use of unstable libraries from a
> trivial userspace emulator. Current users of xendevicemodel.h inherit
> __XEN_TOOLS__ from libxenctrl.h (or equiv).
> ---
... and this patch is broken.
But CI doesn't pick it up because we've also broken the header check
scripts as part of library refactoring.
The 4.13 header checks do work, and point out that there is yet another
set of bogus __XEN_TOOLS__ ifdef in the Xen public ABI, which hides the
ioserverid_t type and (rightly) breaks the build.
Which in turn proves that the header checks (for xendevicemodel.h at
least) never ever checked anything originally, because they didn't pass
__XEN_TOOLS__ in at the top and just saw an empty file.
~Andrew
|
