[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-4.15 0/3] tools: ABI checking


  • To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Mon, 1 Mar 2021 17:30:04 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2qEcyVjdWqgAXa3p4YmBkzcGUrlehgofx17zUGsZcdA=; b=I1pEDjx9jKWjKdHDNzMAtkrxiO6A7L7/gM71KRFqqja8Qh9oH9RwOJF7G8UoedgApg6tTkqAN2jEHQ27KIl+vLKtYoB9Mxy3BLFg+5FXGWQMFCMZtXC14mupSBDSEMjNs/nh2fTEY/Ipaq13VEL7aG5ze+TgjApovOtY+X/cnRKpW4Pik8qPGtVxO6TfowBdTkOaoDwsOfPAUznolbAgNgEFfJPFATGdQJmcLzCY4U6c2NAIkEdG0TCmcDidCUwuN3BuKom7CcPMUUDze4dnS8wUFU4DkdaqHc3lPdqr0uynVzBtvICMIR/+L2Tcn2kD0ub9zXrG0MrZRUuX/8SMAg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UCrk13pYIE+QoRoWAsNpgToWQfDcB1KY3/JioEuZVmmF+/AM9F7q4hi/XrRmcHGtWsW2XnTCq9INs/PCMngn7de1sw1iQMMk9+tAFPRurVCoeAfWXbS81HJg0f2gUj2i6FNqq/XZJx0SfNZAAtRZjuwwyGjj6XGv6Uj04pmPEt3Zz/3eEIeO5rQBFPljm3PoyQnS++QXlv8ytO5crKYV01uJ6RAyehlTYgQ154Gx4zwmnjzV9VDPPIcfBx81aUccX9rIFnKbFPTnUEtk4jpY/McsEyvsnlzrfyjwNKQSCeQAAnSqKWeH9S0BmoA8TQwpG+3VucNBb0bGEPFW1kmjyw==
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
  • Delivery-date: Mon, 01 Mar 2021 17:30:22 +0000
  • Ironport-sdr: l1h6jFfLfxf5qBGBHLppmhL/2BFanr6MYrqn1zG7TcvGN4JhMmL+g54cThvP48ja/cVfhB4j9p 9cEjP52gMkO9c2Xsr8oL5ZOFVtnFtRhYhUvD45RrVhn1ca4jZB+j6zLtjycgEj9Fv6Jcqv59i0 Vyv4xFi8FlypsXW9ojPlyAQ2lq7n35yt69IxNnzq4x8AfrzBnc4UYnVCHNmj+0gZkJinCGqZV9 KEdMI1yBN4GMyZ4+WtSETIH+53swlUWlbtMzBjEvvhv0lF1g1UdViX5MHs5NlNgF84IVBcMhM2 2C8=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 01/03/2021 17:00, Andrew Cooper wrote:
> Support in-tree ABI checking for stable libs.
>
> This series highlights a regression from 4.14, which needs fixing before the
> 3rd patch can be committed.
>
> abi-compliance-checker reports:
>
>   Removed Symbols  3
>     xentoolcore_internal.h
>       xentoolcore__deregister_active_handle ( Xentoolcore__Active_Handle* ah )
>       xentoolcore__register_active_handle ( Xentoolcore__Active_Handle* ah )
>       xentoolcore__restrict_by_dup2_null ( int fd )

Actually, this is fairly easy:

--- ../tools/libs/abi/libxentoolcore.so.1.0-x86_64-abi.dump
+++ ../tools/libs/toolcore/libxentoolcore.so.1.0-x86_64-abi.dump
@@ -4,8 +4,7 @@
           'Arch' => 'x86_64',
           'GccVersion' => '6.3.0',
           'Headers' => {
-                         'xentoolcore.h' => 1,
-                         'xentoolcore_internal.h' => 1
+                         'xentoolcore.h' => 1
                        },
           'Language' => 'C',
           'LibraryName' => 'libxentoolcore.so.1.0',

I'll throw a fix into v2.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.