[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] tools/hvmloader: Drop machelf include as well


  • To: Ian Jackson <iwj@xxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Mon, 1 Mar 2021 16:26:34 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=munAJo8p+PPZUKRMAFwJ9Q9tctpNjFJNpa9dCymRVNM=; b=XQGit4wfJMWRyzr40OKE2jzkuaWRXQhX4maEHJrjlbubzxGYnEJt4AP3640fcGBe4nqJcPzguCi1f5ANsluHgVwsVb6zF/tkN9WXrcTobsRcdKH5Vlmds/l8RBTg8TYf/C5xke8vbvf09qfRBkQjmxxC0GaA5hu21clED+ECoVrDYtc1R9DW6/As/bd9jeSVJnCaQ6ls7HRsOzSI37EWEYFhkpxkD3uI8NvaR5ealDc0Ao0TI7R9owZpWwIH76NRh2Z7XTDs1GqOFOZTWODt/6gNU+5Pb4wPWJSPHGoKNn2xt/V87nDijsjnS4A8ZrlKFcspMjLVeHXVgAAEiByCkw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k5ly2dDnpkZS+Xi0HwkPWdEs6N+j+9Yjs6Z/AsprvXgLaSoVcUYp2ARGDuVuSprg51RBip9hIIw7fyoZwnltCzKz7b9rDNwEKl01XqtApLdji278sz9oJodnw2OQI1/4c+u57Sa9aCTak3grKDVAez5Ykv2kgTYapATrw4jsHvnrnVcQXVxhOKaarpJ7TXg2X5Ylm+68/dhvqB4Q3oxpHBjG9cH0Kjvo3MOPlDDY3GuZaBosZpCPeNlZ75dEz5B5+v8yym8/7ydv3Eipb2xMf7sWKJvUVgYn7n+Sy4HrFJjWU4aAgif63mCDCYvPDZZiwjjv0ZdhowEq8XJjidpeyQ==
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Mon, 01 Mar 2021 16:26:50 +0000
  • Ironport-sdr: a5vYofSjpJ5Kr8pJyeXZLGME0Aah/w/McgYx82Qqw2XJYPbyEq5UvpBADRj49I1oJcuvxT85RQ pR/xNyD2+rNssyJO5oOTUZcH1fO74DS5npngQe/NgsgdHyMyIjSZr1nyyCDbFt0fXM591udQcA 8YnyPv3clOtPUItOsbooEJwh/wDj9BNlgyXABGXOgy86QSi0zMPdcIcxVOrbgOKmAZmu4jbZD/ Ll1ql8Cqm99mPDuReDCfOA27kIcGVg7cJVBAyymP77HPQ8htuYX9118BqdSTujWsXqOtTBfoUZ 9/A=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 01/03/2021 16:16, Ian Jackson wrote:
> Andrew Cooper writes ("[PATCH 1/3] tools/hvmloader: Drop machelf include as 
> well"):
>> The logic behind switching to elfstructs applies to sun builds as well.
>>
>> Fixes: 81b2b328a2 ("hvmloader: use Xen private header for elf structs")
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> I would have preferred this patch to come after the one that is
> actually justified for 4.15, so that it could be held off to after
> 4.15.  After all I see no substantive reason why this should get a
> freeze exception.

It is a bugfix to a very recent patch which already already got a
release ack.

If this doesn't get an ack, then 81b2b328a2 should be reverted.  (Except
obviously that would be a bad move.)

>
> However, it looks fine based on code review and I don't want to add
> risk by asking you to transpose the two patches, so:
>
> Release-Acked-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>

Thanks.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.