Re: [PATCH v3 2/2] VMX: use a single, global APIC access page

[Jan Beulich <jbeulich@xxxxxxxx>]

On 01.03.2021 03:34, Tian, Kevin wrote:
>> From: Jan Beulich <jbeulich@xxxxxxxx>
>> Sent: Monday, February 22, 2021 6:57 PM
>>
>> The address of this page is used by the CPU only to recognize when to
>> access the virtual APIC page instead. No accesses would ever go to this
>> page. It only needs to be present in the (CPU) page tables so that
>> address translation will produce its address as result for respective
>> accesses.
>>
>> By making this page global, we also eliminate the need to refcount it,
>> or to assign it to any domain in the first place.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>

Thanks, but for the record: As said on an unrelated thread already,
I also need to make an adjustment to shadow mode code here. Since
that doesn't affect VMX code itself, I'll retain the R-b on v4
(which I intend to submit only once we have 4.15 branched).

Jan