[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tools: Improve signal handling in xen-vmtrace
- To: Hubert Jasudowicz <hubert.jasudowicz@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 26 Feb 2021 17:44:21 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YknpcX4TnKt0uq0H9eu7tiHhoQ5t7bkxn77kHUtLvT8=; b=ZwqeY0f1AqywObCFQwsxVfQ0alJEVJcGMYCmFqEiuWAHa0k0uDqIC0QVV1qLpNRKO6pWJ/LAMdwD67zOzeDng3R+rYCbZXw34R8P4Hp1cvnrsE3baxzL6pXA5RqG9Jao9gkP5BPgSWQ0x6XNAuO438QzBeKhmTF+gS2dzbgNW7wEULxHOqsw5GRx/xvF1lzn1ElS2J/b6BOU4h8NLdsO1zpl6rruo9LeNWzAav2AP7rOvPSKRWVHDc4ucD72NviVSjgod110xxnZIda8qeRJQGF3/TPw9P4ZuLOS9TGUq5IXgzY75Aucr+PzyXGiF5cn2jdiOFBU+4FzB8tdXFi/5A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IR55csTaO518pPo40zWRo63u93oXXTYDz9bbIsDMbadje3Ji/5tcUhZkitCVqTrjyl3qpsdCD3uSGHeAV2cKxFG4z7lVDtoHKb+QawHYj2eng854/3n2RYjNA+9eoF1FagPGEWkuRa/BEMcEnEZYszkkLaDb3GjHTMfINUrW8/OJgw/5tku+mS4KHfL72CGCy8W+Uji7dFf044P3hF3RW1xpP1TDHDOVRzjWaFfENhn7THJr/sPp5OMnnxdMqPTmrGNCxEd3iZGbzADRpSdLoH45/QTqPYDd5T/WQohzNFyyS3vUErMhtKpgoqVEZnXHvta+toH6kWPpm48Yv+liIA==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Michał Leszczyński <michal.leszczynski@xxxxxxx>
- Delivery-date: Fri, 26 Feb 2021 17:44:41 +0000
- Ironport-sdr: Np7LvF285OgHQivTAT6IEhtxafGNLh7c3xMgDttjpC5FAtPnxLcLRirTDE0WVVUltHKFO7VbUe 268R7MVDeWJPkMV2RNGueQ/K5DG+OfZ9M8TA1edDgt8CrUQl069MgQduQMlAIwtujxslk4TGsy UvQ+H62m3oH9GVCwVEQuoqc4nbyLCpnKph78igj85W1IWzX7UTrEQO2Z5Tdv9mOqIC1z8PArYj eQZVhsbvwcKEGfBPn1yFRDqTsAvtVx1p2RB25dtMdnRwU7ar690bAR+WbQE3yGPlPpl4jyn45E TzU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 26/02/2021 10:59, Hubert Jasudowicz wrote:
> Make sure xen-vmtrace exits cleanly in case SIGPIPE is sent. This can
> happen when piping the output to some other program.
>
> Additionaly, add volatile qualifier to interrupted flag to avoid
> it being optimized away by the compiler.
>
> Signed-off-by: Hubert Jasudowicz <hubert.jasudowicz@xxxxxxx>
Ok, so this is being used in production.
In which case, what other signals potentially need dealing with? Lets
get them all fixed in one go.
When that's done, we should make it installed by default, to match its
expected usecase.
~Andrew
|
