[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [for-4.15][RESEND PATCH v4 2/2] xen/iommu: x86: Clear the root page-table before freeing the page-tables

Hi Jan,

On 24/02/2021 16:00, Jan Beulich wrote:
On 24.02.2021 16:58, Jan Beulich wrote:
On 24.02.2021 10:43, Julien Grall wrote:
--- a/xen/drivers/passthrough/x86/iommu.c
+++ b/xen/drivers/passthrough/x86/iommu.c
@@ -149,6 +149,13 @@ int arch_iommu_domain_init(struct domain *d)
void arch_iommu_domain_destroy(struct domain *d)
+    /*
+     * There should be not page-tables left allocated by the time the
+     * domain is destroyed. Note that arch_iommu_domain_destroy() is
+     * called unconditionally, so pgtables may be unitialized.
+     */
+    ASSERT(dom_iommu(d)->platform_ops == NULL ||

Since you've used the preferred ! instead of "== 0" /
"== NULL" in the ASSERT()s you add further up, may I ask that
you do so here as well?

Oh, and I meant to provide
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
preferably with that cosmetic adjustment (and ideally also with
"uninitialized" in the comment, as I notice only now).

I don't seem to find your original answer in my inbox and on lore [1]. Could you confirm if the two comments visible in this thread are the only one you made on this patch?

Thanks for the review!


[1] https://lore.kernel.org/xen-devel/20210224094356.7606-3-julien@xxxxxxx/


Julien Grall



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.