[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-next] configure: probe for gcc -m32 integer sizes



On 24.02.2021 02:08, Stefano Stabellini wrote:
> --- a/tools/configure.ac
> +++ b/tools/configure.ac
> @@ -307,6 +307,12 @@ AC_ARG_VAR([AWK], [Path to awk tool])
>  
>  # Checks for programs.
>  AC_PROG_CC
> +AC_LANG(C)
> +AC_LANG_CONFTEST([AC_LANG_SOURCE([[#include <stdint.h>
> +#define BUILD_BUG_ON(p) ((void)sizeof(char[1 - 2 * !!(p)]))
> +int main() { BUILD_BUG_ON(sizeof(uint64_t) != 8); }]])])
> +AS_IF([gcc -m32 -c conftest.c -o /dev/null 2>/dev/null], [hvmloader=y], 
> [AC_MSG_WARN(hvmloader build disabled due to headers mismatch)])
> +AC_SUBST(hvmloader)
>  AC_PROG_MAKE_SET
>  AC_PROG_INSTALL
>  AC_PATH_PROG([FLEX], [flex])

I'm fine with the approach now, but I'm rather uncertain about
the insertion point you've selected (in the middle of the
"Checks for programs" section). It'll need to be the tools
maintainers to judge about this.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.