[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Stable ABI checking (take 2)

  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Mon, 22 Feb 2021 16:00:43 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SfhWJERM8VMjLdeL9m2QrAHCx8VmAP9Id6a8RwnXkVY=; b=fqG04hFyDCxQl5zGI1jvjdVecn+X/9Yl1FkO36W+q3AsmOWcXZ4I9Tj/vAfmRtwuS8Y6FLOdlQBEoHgbm/fGUUfKEOY0i6L+T234AOsDJdI0vCrxcv7nMA+7InWYpxGyHs1u/AOa5kTaf3250ClmZdPkNOvysKaFJau0JYPpP5/SNffXQ5ew5huz9wlsXslzY/ixtjs5lO38wsRvS/9/8Hgw+20EaJXyFIFpFUCiQyHuO3qY4T5tnPQvfP34PgPz8/q4LpayKeOrCJKw/NQ0hO+Pdi1MtDmiJXiR2p3o+4YBwPQ2FKA/ASDywDGgJpno5brzeKKp4CVBgt5j3SRzTw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BAFvJP5cwAxJASgWpE+4apIJMIq5Na07us7E/PweJTDsuCXaECE2y4N8H+5BzMSU+lq9/McrLCQxdk6Ukp1CzOGaRf83/kG3Bc2u7YGU/8tj3/vSzw2sY/CX8cpHSdaf7DLBIHWIkyVGeY2OQCOl455gtNTvJl03RHbI96gdXtBnTFp9ECOUDQUWwiSFIEv94WmTMhx5LTeZ1WubbzGipS8lgu5MHooFSN5Vxu6qqHzZEQUqgu/A+x+odA/DqGMp0ouqEx4XkNmipvAAk+FyJgyK9sGtIq6qIq4WMdCKimB/n2w2txVzz0+glMKZk3UUCbXuOyoj4zNoMpP3Kz+zcA==
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxx>
  • Delivery-date: Mon, 22 Feb 2021 16:01:01 +0000
  • Ironport-sdr: HCd/iBAf1l0DUOCyhHAIDgHIeEuaIKtyPscas30o7OliN2iE+5khxwz4mshOhjy56VyfKV4Uau hYU3ZommW53wHlL/GrHg1UC4B1dxBiAbrFhaQPZXJXbKZfdmFTQPfZAhAQ08N7iqcZ+qiTHwBB 7JLdl/DnHy/t3+W+77LuIS21eYghQ24EfHmLWHP5AefTaA257p+VtsmI08lb6ZKBo6ODLpaOGp rL91DygK8JqwzW2JWdNohD2XxLQuhYnSz9tpNW9ItwMUvXUU/gR1Gxyvo38eQ+Dk2DzhwpAmRr Ijs=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 22/02/2021 14:37, Jan Beulich wrote:
> On 22.02.2021 15:03, Andrew Cooper wrote:
>> Hello,
>> Staging is now capable of writing out an ABI description when the
>> appropriate tool (abi-dumper) is available.
>> We now have to possible courses of action for ABI checking in builds.
>> 1) Publish the ABI descriptions on xenbits, update all downstream test
>> systems to invoke abi-compliance-checker manually.
>> 2) Commit/update the ABI descriptions when RELEASE-$X.$Y.0 is tagged,
>> update the main build to use abi-compliance-checker when available.
>> Pros/Cons:
>> The ABI descriptions claim to be sensitive to toolchain in use.  I don't
>> know how true this is in practice.
>> Publishing on xenbits involves obtaining even more misc artefacts during
>> the build, which is going to be firm -2 from downstreams.
>> Committing the ABI descriptions lets abi checking work in developer
>> builds (with suitable tools installed).  It also means we get checking
>> "for free" in Gitlab CI and OSSTest without custom logic.
>> Thoughts on which approach is better?  I'm leaning in favour of option 2
>> because it allows for consumption by developers and test systems.
> +1 for option 2, fwiw.
>> If we do go with route 2, I was thinking of adding a `make check`
>> hierarchy.  Longer term, this can be used to queue up other unit tests
>> which can be run from within the build tree.
> Is there a reason the normal build process can't be made fail in
> case verification fails? Besides "make check" typically meaning to
> invoke a functional testsuite rather than (just) some compatibility
> checking, I'd also be worried of no-one (likely including me) to
> remember to separately run "make check" at appropriate times.

As far as RPM is concerned, splitting the two is important, as %build
and %check are explicitly separate steps.  I have no idea what the deb
policy/organisation is here.

Merging some of check into build would be a layering violation, and even
if we did so, where do you draw the line?




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.