[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen-tip:linux-next 7/9] drivers/net/xen-netback/netback.c:1334:17: warning: variable 'ret' set but not used


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: kernel test robot <lkp@xxxxxxxxx>
  • Date: Wed, 17 Feb 2021 04:32:23 +0800
  • Cc: kbuild-all@xxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, Juergen Gross <jgross@xxxxxxxx>
  • Delivery-date: Tue, 16 Feb 2021 20:33:50 +0000
  • Ironport-sdr: LAA8r5tqFopAUoYD3slXWUSDDSvMVaZy2BOf28Wo1lcOiZ4GgvKaqWHqlTNW7jnSow680K/j5s DqULvWKcIa7w==
  • Ironport-sdr: O3TYxgWpYaZMEDeoLfJ/XLyCgDv8FxJsm/dR9UgygIEi+XwZJ+2VFpV6AVukU8vMyGCv0f9QeR lvfqtRPwITbg==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git linux-next
head:   871997bc9e423f05c7da7c9178e62dde5df2a7f8
commit: 3194a1746e8aabe86075fd3c5e7cf1f4632d7f16 [7/9] xen-netback: don't 
"handle" error by BUG()
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # 
https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git/commit/?id=3194a1746e8aabe86075fd3c5e7cf1f4632d7f16
        git remote add xen-tip 
https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git
        git fetch --no-tags xen-tip linux-next
        git checkout 3194a1746e8aabe86075fd3c5e7cf1f4632d7f16
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross 
ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   drivers/net/xen-netback/netback.c: In function 'xenvif_tx_action':
>> drivers/net/xen-netback/netback.c:1334:17: warning: variable 'ret' set but 
>> not used [-Wunused-but-set-variable]
    1334 |  int work_done, ret;
         |                 ^~~


vim +/ret +1334 drivers/net/xen-netback/netback.c

3e2234b3149f66 Zoltan Kiss  2014-03-06  1328  
f53c3fe8dad725 Zoltan Kiss  2014-03-06  1329  
f942dc2552b8bf Ian Campbell 2011-03-15  1330  /* Called after netfront has 
transmitted */
e9ce7cb6b10740 Wei Liu      2014-06-04  1331  int xenvif_tx_action(struct 
xenvif_queue *queue, int budget)
f942dc2552b8bf Ian Campbell 2011-03-15  1332  {
bdab82759b8e36 Zoltan Kiss  2014-04-02  1333    unsigned nr_mops, nr_cops = 0;
f53c3fe8dad725 Zoltan Kiss  2014-03-06 @1334    int work_done, ret;
b3f980bd827e6e Wei Liu      2013-08-26  1335  
e9ce7cb6b10740 Wei Liu      2014-06-04  1336    if 
(unlikely(!tx_work_todo(queue)))
b3f980bd827e6e Wei Liu      2013-08-26  1337            return 0;
f942dc2552b8bf Ian Campbell 2011-03-15  1338  
e9ce7cb6b10740 Wei Liu      2014-06-04  1339    xenvif_tx_build_gops(queue, 
budget, &nr_cops, &nr_mops);
f942dc2552b8bf Ian Campbell 2011-03-15  1340  
bdab82759b8e36 Zoltan Kiss  2014-04-02  1341    if (nr_cops == 0)
b3f980bd827e6e Wei Liu      2013-08-26  1342            return 0;
f942dc2552b8bf Ian Campbell 2011-03-15  1343  
e9ce7cb6b10740 Wei Liu      2014-06-04  1344    
gnttab_batch_copy(queue->tx_copy_ops, nr_cops);
3194a1746e8aab Jan Beulich  2021-02-15  1345    if (nr_mops != 0)
e9ce7cb6b10740 Wei Liu      2014-06-04  1346            ret = 
gnttab_map_refs(queue->tx_map_ops,
f53c3fe8dad725 Zoltan Kiss  2014-03-06  1347                                  
NULL,
e9ce7cb6b10740 Wei Liu      2014-06-04  1348                                  
queue->pages_to_map,
9074ce24932186 Zoltan Kiss  2014-04-02  1349                                  
nr_mops);
f942dc2552b8bf Ian Campbell 2011-03-15  1350  
e9ce7cb6b10740 Wei Liu      2014-06-04  1351    work_done = 
xenvif_tx_submit(queue);
b3f980bd827e6e Wei Liu      2013-08-26  1352  
b3f980bd827e6e Wei Liu      2013-08-26  1353    return work_done;
f942dc2552b8bf Ian Campbell 2011-03-15  1354  }
f942dc2552b8bf Ian Campbell 2011-03-15  1355  

:::::: The code at line 1334 was first introduced by commit
:::::: f53c3fe8dad725b014e9c7682720d8e3e2a8a5b3 xen-netback: Introduce TX grant 
mapping

:::::: TO: Zoltan Kiss <zoltan.kiss@xxxxxxxxxx>
:::::: CC: David S. Miller <davem@xxxxxxxxxxxxx>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.