[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 01/10] tools/xl: Fix exit code for `xl vkbattach`

Andrew Cooper writes ("[PATCH 01/10] tools/xl: Fix exit code for `xl 
> Various version of gcc, when compiling with -Og, complain:
>   xl_vkb.c: In function 'main_vkbattach':
>   xl_vkb.c:79:12: error: 'rc' may be used uninitialized in this function 
> [-Werror=maybe-uninitialized]
>      79 |     return rc;
>         |            ^~
> The dryrun_only path really does leave rc uninitalised.  Introduce a done
> label for success paths to use.
> Fixes: a15166af7c3 ("xl: add vkb config parser and CLI")
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.