[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 09/10] tools/libs: Add rule to generate headers.lst

Andrew Cooper writes ("[PATCH 09/10] tools/libs: Add rule to generate 
> abi-dumper needs a list of the public header files for shared objects, and
> only accepts this in the form of a file.

Release-Acked-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>

because it's not run by default, but...

> +headers.lst: FORCE
> +     @{ $(foreach h,$(LIBHEADERS),echo $(h);) } > $@.tmp

Missing set -e.  If the disk fills up temporarily you might get a
partial file here...

> +     @$(call move-if-changed,$@.tmp,$@)




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.