[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] VMX: use a single, global APIC access page


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Wed, 10 Feb 2021 17:00:18 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ud91ZUGiELp7dK+WvV+JKkvJnwquss6sCLbZsKcKllQ=; b=adaEjeKGju3bWabD0PxtKcWCWXT4JpRK6zJWftMAHFM1eYX9bPhJqNI8MEoq+lSDcZFdeZBYr0Ew9wcJrGdsSRM60vsNMRYvmVt+Y5nP2XYHzcgh0x0l5Jb+piZOt1GX3PvIxUmd2LQcOhpdqiFlw+c03YIxNFpwMIzmT3ugsib4e9n5nH5S6joPvNkZuhI+PYYu9WWqzZhHNGUtD5vxMC3Jx7ZCHRawj1Sjkn0CCaxRC7Sb7AGwcS+xLUT7dazUcb/3PrwaFR7E25SGW4Bm4PS1NeClBchC3Irit1kIMJ74VxVjjC5mkucLrqiCM4QMipoFXfLF0R6KA7uE0OMqRQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f6zYwy/g4hkrXE8u35DFzPg37Um+LkPdNedzJTHuEyzTTBZavjIC+peMCsClFRjWG9vGf1/6gJn+m19yiwAa+4RpOMNAY1Vb4V6Ejs0/RPoWNrUVfvRUkXdIbJN8JVLu+0s0NoNrKTi6tV0036AuMZ8aBvo3o2kpPA/d2sbkUp2aXF0j16pLB8S4Tfvhh1RDfVnqfLjQ10yoWYAWej/CwUdKmP5hwCMy41/g7/2y5ARnbcFs40pSlp53stGMJ2UcLuv8vJLbcv/n5RCKQrFIiTB/UxFYF3dvLzdt5hCXJZO4zaRnmn1Cbqefrjp0y1C9uQW1YJxbS4ibirLEbOyajg==
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Kevin Tian <kevin.tian@xxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Wed, 10 Feb 2021 17:00:34 +0000
  • Ironport-sdr: DtCNs9wZPliw90ZVdn/6IdryXwlSK0eUT9Tz12zSDkBIaL60s+JZhKP+LWG07lhARHy8We6dgG j3Fxmx3l8EOoRMeBq56XOhRY1iEhQYuTkdm8XAXHbHzIg+7ego+hCO2aOZgKUHO5EceWnpMpln KS1fajXWxOlh3sD9MUN7uy/tOcE1CBUdEbui79gLZI/58aakfKvV0DlDlPl0yRa32at0BEfzLQ mSa10qaMPouMI0HWPBzz2soqmg6O0wfvbvrM3MHgoLR7UMIHOI6rZE7kZrQiNXd/C0chcuWygl e+Q=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 10/02/2021 16:48, Jan Beulich wrote:
> The address of this page is used by the CPU only to recognize when to
> instead access the virtual APIC page instead. No accesses would ever go
> to this page. It only needs to be present in the (CPU) page tables so
> that address translation will produce its address as result for
> respective accesses.
>
> By making this page global, we also eliminate the need to refcount it,
> or to assign it to any domain in the first place.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

How certain are you about this?

It's definitely not true on AMD's AVIC - writes very definitely end up
in the backing page if they miss the APIC registers.

This concern was why we didn't use a global page originally, IIRC.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.