[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] xen: workaround missing device_type property in pci/pcie nodes


  • To: Stefano Stabellini <sstabellini@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Tue, 9 Feb 2021 20:02:41 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nOAoT+g4WqRsMZuM9rfXCyGWS86HflA8SSBIFOTmXko=; b=ciGzT0/rGHIlBvhIvg9JyR5qbUb9HB1jiIWCE7gXea1lh6YCP9+goEqpI/dm7ojUBbt56MfJy2nJJWYLn4A2gMPGGYEprZ64cdBuvNyPv18BPl7gfjAMSNJ+186jciTOnrupAx9FBFWW4jGvdbx1tMcPW8cJ9zpqv0HxPi2VqgTKuMu/XHO9t5SuMnEwBmGJHroUUH7GEp2RG16NOMi1Ffnm+vrO2KvgHXZ2ctlD70icGtnFbOcQsTSOyDHrdBBT9/g6FOzfskonOPAITbFlS7+aXPGEEHZJipaj20WuFf4mGqnezhBRkzPqPxRzIOD4Edk9lbDtS4hGVep2ql7YLw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jImxHux7MqiS/AL69Y75DZ3KblRv32s7yAOvXTgRNPwusKjJAPoH/nzGV6DEOSpA+/VSMN3r4ObMfd9ys7vPRBzlI7Qm0XyF3XEH4CuGlovgFbdXZ0Tprn+JslOUsT2lbqeR9dFyNzrDHyYgTa6AmfWrDOZsDA0SQJeyFXwWdXM9FCN3t2yz1vmt6tAIHyC38qkrMjF/v9ZeWI827Z/wDCWRAEJOU63r7oYHivTAgoJyYWcUd7RD2H6wtkwseGJAwtdm0LPFZhBI7z3GxEw7+Yoh6uvvqr1dCDrli5gj3rnAypcDZ9iWG1wPo4wk+HZeTURpg0hHhvPnVzXACkCufg==
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: <julien@xxxxxxx>, <Volodymyr_Babchuk@xxxxxxxx>, <ehem+xen@xxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
  • Delivery-date: Tue, 09 Feb 2021 20:03:11 +0000
  • Ironport-sdr: 3Sc4b73rnR4qID9eZCIvziHY7zr0yzJA7NhBMn504csyx/ynXpdaDHO5vaE5xZAGsD/uuBqHVT Qblt8dO3Sw/P7B7kukSxS5i2GrmkIBCkxIA3WKh1kKXSyiY7Qpy4IkuM1P5dxbfevNe4QAWXum KBrshqUt1lksvKpMSQcTvivRfaCuNNz9e3MG+pXm5Gs22Bh4JIopm/URSObAbEwNwUMy02R20u qMLzG538E4AvF1jPN8Rh0Cz+NyoBKshrJZHMuUjRUG8ZWZoLuIAttpxlPcUR46H7aGwPwUHmdI TAY=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 09/02/2021 19:53, Stefano Stabellini wrote:
> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
> index 18825e333e..f1a96a3b90 100644
> --- a/xen/common/device_tree.c
> +++ b/xen/common/device_tree.c
> @@ -563,14 +563,28 @@ static unsigned int dt_bus_default_get_flags(const 
> __be32 *addr)
>   * PCI bus specific translator
>   */
>  
> +static bool_t dt_node_is_pci(const struct dt_device_node *np)
> +{
> +    bool is_pci = !strcmp(np->name, "pcie") || !strcmp(np->name, "pci");
> +
> +    if (is_pci)

bool on the function, and spaces here, which I'm sure you can fix while
committing :)

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.