Re: [PATCH v20210111 05/39] tools: add with-xen-scriptdir configure option

[Ian Jackson <iwj@xxxxxxxxxxxxxx>]

Olaf Hering writes ("Re: [PATCH v20210111 05/39] tools: add with-xen-scriptdir 
configure option"):
> The reason is the ordering of assignments in the file:
> AC_ARG_WITH comes early in the file, XEN_CONFIG_DIR= is assigned much later.

Ah.

> It seems the assignments for CONFIG_DIR and XEN_CONFIG_DIR can be moved up, 
> because $sysconfdir is expected to be set already. As a result the new 
> AC_ARG_WITH= can continue to use "$XEN_CONFIG_DIR/scripts" for the default 
> case.

That would be best I think.

> I assume the current ordering is to have a separate AC_ARG_WITH and AC_SUBST 
> section.

I could be wrong, but I don't think the location of AC_SUBST matters.

Ian.