Re: [PATCH] xen/arm: domain_build: Ignore device nodes with invalid addresses

[Julien Grall <julien@xxxxxxx>]

Hi Stefano,

On 04/02/2021 22:39, Stefano Stabellini wrote:
> After the discussion with Rob, it is clear that we have to add a check
> on the node name for "pcie" in dt_bus_pci_match. However, that wouldn't
> solve the problem reported by Elliot, because in this case the node name
> is "pci" not "pcie".
I'd like to point out that in the Linux case, the problem was in the 
hostbridge and not the PCI device.
> I suggest that we add a check for "pci" too in dt_bus_pci_match,
> although that means that our check will be slightly different from the
> equivalent Linux check. The "pci" check should come with an in-code
> comment to explain the situation and the reasons for it to be.
I'd like to follow the same approach as a Linux commit:

commit d1ac0002dd297069bb8448c2764c9c31c4668441
Author: Marc Zyngier <maz@xxxxxxxxxx>
Date:   Wed Aug 19 10:42:55 2020 +0100

    of: address: Work around missing device_type property in pcie nodes

This means a warning should also be added.

Cheers,

--
Julien Grall