[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] tools/libxl: only set viridian flags on new domains
- To: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 5 Feb 2021 18:59:22 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ho9WuhTbVpwK/VfA1t6b1i2htzxQfFJD+14VX5n/ZJY=; b=LQF6pGJCRrL/QbU5BuGQrgqiU/FS/xMuh8KoCsCAAurZbzeYUW14C9M40dVGxes6sp6YUaG8Ye9Ik2JtH2PGNFfhiHyYTlP9E85crH1nJ0XhnXc51I6j65ilOdN92L73jJrM/lzZBkPWvzXbVO3vmDLWo1lqtn7VgtjPh/5Tb3IAWmMN3bKjqx5Kx99vSrOJkYnKUbViar1DsSEKKodqdwsSTuW6GOo6XpHjgvam1T3YPxkbKuRW/Y+PUvLmdclbDBWtHNLVPZHJBAq2kFClZcjN8OCePZJQzkjvCEx6qgxDiJOUaFVU43ZI/w9OM3bZrY+41bg3t+JLgdVtUM5Wuw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OJeMFi/M5MnROJCcs6IqMrTaCtSw0L9bTxwFPplONvJE9RRNkyIDNAX/LHe4JpdvUqlzYykT1LSQaQZs6Cp03Bs4kkdB3QyziLUa7qZq4rFc2JWPfPwEU0ARAO5YM/PEy5kMNeRysdiFDxArfXh2B0SRQAGLT7ca2dCmJFJZUgTpt1ufWFlkR6Iv0YT9DoYVtLg5ux/Z7D1lPsaP8daO00i5zAneKqyxpuiXigBiifZyFSJ2Pa+QcFVstrm4kpSllR0xJvxSo8Ud62PM9RB1V9njMEcYINdGF/f6PhMzAjupXW8+Zgl6rYoWWJ4TqDpoNLgl7aW2K5YP/JM06KAh1w==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <wl@xxxxxxx>, <anthony.perard@xxxxxxxxxx>, <tamas.k.lengyel@xxxxxxxxx>
- Delivery-date: Fri, 05 Feb 2021 18:59:40 +0000
- Ironport-sdr: zi4v/2zyY0YU2RkStvzV6+kGgUegRmgfkQljhiK2VrM3FvgKwaaN3+vRCVHvFf8/v7l/u8mqdy tgTSLgCQLXc+6nQ3WENKiAq1fN2oWh+ZVYBmtnX8JWR902BiMW7c7WNjwEn6Jg2Y9iEkmcWovb zedVgsGo/EYkYIYhEwGy1LQsi1mbahkhgNS0+IqLTrOTdx2olvLkJluEWR8U5a1k9HhzN8Jyti Qs+iKuOIIfWO+70ciryOuiOY3UEwB7S3JvfU9QwgTnE5wVBZWvXsQetOteSKN4cypv/1eWdpF/ gaU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05/02/2021 18:46, Ian Jackson wrote:
> Igor Druzhinin writes ("[PATCH v2 2/2] tools/libxl: only set viridian flags
> on new domains"):
>> Domains migrating or restoring should have viridian HVM param key in
>> the migration stream already and setting that twice results in Xen
>> returing -EEXIST on the second attempt later (during migration stream
>> parsing)
>> in case the values don't match. That causes migration/restore operation
>> to fail at destination side.
>>
>> That issue is now resurfaced by the latest commits (983524671 and 7e5cffcd1e)
>> extending default viridian feature set making the values from the previous
>> migration streams and those set at domain construction different.
>>
>> Suggested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> Signed-off-by: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
> Thanks for splitting this up.
>
> Release-Acked-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>
>
> Andy, I think from irc that this meets with your approval but can I
> have a formal R-b ? If so please put my tools maintainer ack on it
> too.
Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
