Re: [PATCH for-4.15] libs/devicemodel: Fix ABI breakage from xendevicemodel_set_irq_level()

[Oleksandr <olekstysh@xxxxxxxxx>]

On 04.02.21 17:58, Andrew Cooper wrote:

Hi Andrew

> It is not permitted to edit the VERS clause for a version in a release of Xen.
>
> Revert xendevicemodel_set_irq_level()'s inclusion in .so.1.2 and bump the the
> library minor version to .so.1.4 instead.
>
> Fixes: 5d752df85f ("xen/dm: Introduce xendevicemodel_set_irq_level DM op")
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Ian Jackson <iwj@xxxxxxxxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
> CC: Julien Grall <julien.grall@xxxxxxx>
> CC: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> CC: Wei Chen <Wei.Chen@xxxxxxx>
>
> Critical to include in 4.15, as this is an ABI breakage.
I am sorry for the breakage, I admit I didn't know that
"It is not permitted to edit the VERS clause for a version in a release 
of Xen."

>    Reverting the broken
> change doesn't look to be a practical option.
> ---
>   tools/libs/devicemodel/Makefile              | 2 +-
>   tools/libs/devicemodel/libxendevicemodel.map | 6 +++++-
>   2 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/tools/libs/devicemodel/Makefile b/tools/libs/devicemodel/Makefile
> index 500de7adc5..3e50ff6d90 100644
> --- a/tools/libs/devicemodel/Makefile
> +++ b/tools/libs/devicemodel/Makefile
> @@ -2,7 +2,7 @@ XEN_ROOT = $(CURDIR)/../../..
>   include $(XEN_ROOT)/tools/Rules.mk
>   
>   MAJOR    = 1
> -MINOR    = 3
> +MINOR    = 4
>   
>   SRCS-y                 += core.c
>   SRCS-$(CONFIG_Linux)   += common.c
> diff --git a/tools/libs/devicemodel/libxendevicemodel.map 
> b/tools/libs/devicemodel/libxendevicemodel.map
> index a0c30125de..733549327b 100644
> --- a/tools/libs/devicemodel/libxendevicemodel.map
> +++ b/tools/libs/devicemodel/libxendevicemodel.map
> @@ -32,10 +32,14 @@ VERS_1.2 {
>         global:
>                 xendevicemodel_relocate_memory;
>                 xendevicemodel_pin_memory_cacheattr;
> -               xendevicemodel_set_irq_level;
>   } VERS_1.1;
>   
>   VERS_1.3 {
>         global:
>                 xendevicemodel_modified_memory_bulk;
>   } VERS_1.2;
> +
> +VERS_1.4 {
> +       global:
> +               xendevicemodel_set_irq_level;
> +} VERS_1.3;
--
Regards,

Oleksandr Tyshchenko