[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.15] x86/efi: enable MS ABI attribute on clang
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 3 Feb 2021 19:10:49 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L+dtwTpfiUA9Jrs29DLC3iQ37Wh7rLi2dpTVGGU2vOM=; b=U6s0Wvj+rLpBX7FHNawJdMuy8S/325SI4ONG8vIyhTxpahJBs9jZWCgdvwwdhM8RB/te5gVWXuK8x19ELYZWQNDjSJuj/Aabf0Fy7XCQXz3tWO1CngKBebqzYFOSoJet26Mlq2aGoHqntvrgm+WPi4fEayZYPKBvrbnf/g3HTGoC9bYx9o9xpYRiHILw2zdrB22NcMpu0L9LaEc8XuxmF/ZrVD+zJiN0ZLv393ATRpzobmuN940hou7wew6GYKOhvYslP+BSj3IK8CpppHkWaszSzPh6G7kQfPPROLe6KFbpK1tALSrb619jNqyIGNbETP20NsV5sAPYLPTjviz75w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QfFtU9hZEOMeHWXjmv1kPGgIfa2l0aGdVfBAuXHGEAlG4yedtqfMCN3lLM/rCPkl19axoc3rbTtAw0pptGDyRQdiYQKNqJCHjzJECTc0WowI8nVS+CUPbhGU4+doYnJ5XiH53FglmnWR+E2RyPeyNFABl4Bkl1VMMRTub3rB0k5pT+vKpDI69iyea1fBUbneciOvrhFOoO2gm2G72uQ1OTvICbVrwFFgdfrgb791My9PUs+ZmW4uRhOZxik1lb2p9q45eJ+nbHqDYV28uORJ6X2JtHgmYzMSGppVxKRiRcB9xC6f2u2GN3j0NZmNXWQJEPgzr4pVFXd92HyBfeV2OA==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>
- Delivery-date: Wed, 03 Feb 2021 19:11:19 +0000
- Ironport-sdr: RIK8rXJgwVN8lN1f6khucoH41vSVUvaSTdYfvlOHApGOFaVT5a2k7X6dpEoROEqBIerMXmubE1 abPbzsoiYZfRw3pueKW2XWdH6fymF/uzmke3Lvw/4THXifjdp9Pha5RSo3V5RIvd7ba9UoTksA XKin55ALPTrGF9/14th6/D1pb5YsvWVmn9sK3sP/8HmewFNv5l4vUQyhru0yTgXOHJBl498uGr He+aNMCWtcdAvOitBT4xVdXln2vlM6KXeEV7dsLzB4E0VvOGaP2kcMp8HvP7826lElc1M4Ma/K 5h8=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 03/02/2021 17:58, Roger Pau Monne wrote:
> Or else the EFI service calls will use the wrong calling convention.
>
> The __ms_abi__ attribute is available on all supported versions of
> clang.
>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>
>
> Without this a Xen built with clang won't be able to correctly use the
> EFI services, leading to weird messages from the firmware and crashes.
> The impact of this fix for GCC users is exactly 0, and will fix the
> build on clang.
DYM "fix the compiled binary"?
The build on clang isn't broken atm, but it provably has the wrong ABI.
~Andrew
|
