[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 0/3] Generic SMMU Bindings

  • To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • From: Rahul Singh <Rahul.Singh@xxxxxxx>
  • Date: Tue, 2 Feb 2021 16:07:08 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EztLR4nuMtzO5tLprYC7gPR+MPCHYmw5ocLwT05Q2N0=; b=nVihpXCYkk7NDXLdwRvSlAu0urF0QMiVk0JokrXdy/h668Se7U8P5BfgPmNbuJ5VjbZuWfOn903A7gWDg6g7BZwmd2pmCTiqsYumwdwNmA/BkxbR6sRVppFe1EIJcSuaWJnQ9cGR1qOgU8FOGZfRy+RHywkr0D/h1gWqq1mdeGu/Dy9WtNFG142694aWf9OFniwjyaqPkj0bkceU1HDO2pTpPVKpxYEkl3rIWxc4roRprT3cfjl5zYlHLzqyz/bn786XNnZIBrvWdOAAmZFGP4vNlN7yVAWF9oslFXgRK2ouE39myL+iGgFUER1EAB5Peq/iceiiyBnvPBCnyeHVDg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SpvafVGqkJpJSh6afI15GpR8s3kRyN6EGxe4rc8v5APehPeZpHlno1WCj8bWUzF7njIUl209uCdLlV7FwD2fm+9w2QgKODaTn1/rdpnHZ/9TmZRuWdaE0l/5hGYQ4sDAM0ErqIIwT27qns/9giZTmpJHh41ka53mj/ftDAJ+z2meDF7bXcQ7HPAvPSZVD127e65JyRruGc8HWd8B4Gd2bm1I/nzpptAu8/JjzWPJ2D+kmzmAnuBGd4jX5jfBAKJOuGhD1ioVztPvw3JHZsnTxVLMIl20VgA+AZ+6YLzWyDEVkBiex9H4vsPuJeGmLbUuGZ68Pl4gAlyKvdjtxRlzkA==
  • Authentication-results-original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
  • Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "Volodymyr_Babchuk@xxxxxxxx" <Volodymyr_Babchuk@xxxxxxxx>, "brian.woods@xxxxxxxxxx" <brian.woods@xxxxxxxxxx>
  • Delivery-date: Tue, 02 Feb 2021 16:07:53 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHW9DbnaDtcsjSAAUiKSXHzYBU+iapFEnqA
  • Thread-topic: [PATCH v3 0/3] Generic SMMU Bindings

Hello Stefano,

> On 26 Jan 2021, at 10:58 pm, Stefano Stabellini <sstabellini@xxxxxxxxxx> 
> wrote:
> Hi all,
> This series introduces support for the generic SMMU bindings to
> xen/drivers/passthrough/arm/smmu.c.
> The last version of the series was
> https://marc.info/?l=xen-devel&m=159539053406643
> I realize that it is late for 4.15 -- I think it is OK if this series
> goes in afterwards.

I tested the series on the Juno board it is woking fine.  
I found one issue in SMMU driver while testing this series that is not related 
to this series but already existing issue in SMMU driver.

If there are more than one device behind SMMU and they share the same 
Stream-Id, SMMU driver is creating the new SMR entry without checking the 
already configured SMR entry if SMR entry correspond to stream-id is already 
configured.  Because of this I observed the stream match conflicts on Juno 

(XEN) smmu: /iommu@7fb30000: Unexpected global fault, this could be serious
(XEN) smmu: /iommu@7fb30000:    GFSR 0x00000004, GFSYNR0 0x00000006, GFSYNR1 
0x00000000, GFSYNR2 0x00000000

Below two patches is required to be ported to Xen to fix the issue from Linux 


> Cheers,
> Stefano
> Brian Woods (3):
>      arm,smmu: switch to using iommu_fwspec functions
>      arm,smmu: restructure code in preparation to new bindings support
>      arm,smmu: add support for generic DT bindings. Implement add_device and 
> dt_xlate.
> xen/drivers/passthrough/arm/smmu.c    | 162 ++++++++++++++++++++++++----------
> xen/drivers/passthrough/device_tree.c |  24 ++---
> 2 files changed, 123 insertions(+), 63 deletions(-)



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.