RE: [PATCH] hw/i386/xen: Remove dead code

[Paul Durrant <xadimgnik@xxxxxxxxx>]

> -----Original Message-----
> From: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
> Sent: 02 February 2021 15:57
> To: qemu-devel@xxxxxxxxxx
> Cc: Richard Henderson <richard.henderson@xxxxxxxxxx>; Paolo Bonzini 
> <pbonzini@xxxxxxxxxx>; Eduardo
> Habkost <ehabkost@xxxxxxxxxx>; qemu-trivial@xxxxxxxxxx; Michael S. Tsirkin 
> <mst@xxxxxxxxxx>; Marcel
> Apfelbaum <marcel.apfelbaum@xxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx; Paul 
> Durrant <paul@xxxxxxx>;
> Anthony Perard <anthony.perard@xxxxxxxxxx>; Stefano Stabellini 
> <sstabellini@xxxxxxxxxx>; Philippe
> Mathieu-Daudé <philmd@xxxxxxxxxx>
> Subject: [PATCH] hw/i386/xen: Remove dead code
> 
> 'drivers_blacklisted' is never accessed, remove it.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>

FTR this is a vestige of an ancient mechanism that's not used any more (see 
https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=docs/misc/hvm-emulated-unplug.pandoc
 step 5).

Reviewed-by: Paul Durrant <paul@xxxxxxx>

> ---
>  hw/i386/xen/xen_platform.c | 13 ++-----------
>  1 file changed, 2 insertions(+), 11 deletions(-)
> 
> diff --git a/hw/i386/xen/xen_platform.c b/hw/i386/xen/xen_platform.c
> index 7c4db35debb..01ae1fb1618 100644
> --- a/hw/i386/xen/xen_platform.c
> +++ b/hw/i386/xen/xen_platform.c
> @@ -60,7 +60,6 @@ struct PCIXenPlatformState {
>      MemoryRegion bar;
>      MemoryRegion mmio_bar;
>      uint8_t flags; /* used only for version_id == 2 */
> -    int drivers_blacklisted;
>      uint16_t driver_product_version;
> 
>      /* Log from guest drivers */
> @@ -245,18 +244,10 @@ static void platform_fixed_ioport_writeb(void *opaque, 
> uint32_t addr, uint32_t v
> 
>  static uint32_t platform_fixed_ioport_readw(void *opaque, uint32_t addr)
>  {
> -    PCIXenPlatformState *s = opaque;
> -
>      switch (addr) {
>      case 0:
> -        if (s->drivers_blacklisted) {
> -            /* The drivers will recognise this magic number and refuse
> -             * to do anything. */
> -            return 0xd249;
> -        } else {
> -            /* Magic value so that you can identify the interface. */
> -            return 0x49d2;
> -        }
> +        /* Magic value so that you can identify the interface. */
> +        return 0x49d2;
>      default:
>          return 0xffff;
>      }
> --
> 2.26.2