[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/build: correctly record dependencies of asm-offsets.s
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 1 Feb 2021 15:06:41 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=atXN1GxkEwQE8MMSncvh83/fWaw7vuSzU/q8wa+hX3g=; b=E1zFr9vBeLw9JR1Xi3MeEg0Xq96wY5AvcVEgveKa2ZusUrEqOuXwr16ceBbtI5HybjN+kP3KyKLSxNqDbHWvaF5hkyri0jmeRhqtTJM9T/GaabBh0SGAl6Qr6pLaAinyV0l3n/VSMXxcfbQZdcETA7oje141Ne4/TP5lTWFvZMCUkntZfCUQkoZu+0e+P+ySQB8jw7s8YEpx6N9VbiqaEHnwrmsg87wsL5pJGtMhTlkxZomXfrk6L0OrIUjhmGz8fbtyLxkkFgzedHgxqOHmkv/5jFKrltJM9zWWTUgwzsSmvD9q2Koo43Cu0ydc7DkWkJylh+Aka7bDwkXUHThXpg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ILQ8kmlPAednR6jK1EeYa6nSOHIMj6OpNIbvUBFLCmWEm+Oyl2/UGMTSnA+wnmaDV83z3RpydhTKWT/MAoTtRbQ11LRy9IbuQtMYFQFW96clK4kNfgeLyrEqB7voYepnFp+YBW0VZsvCuG6GVGhBwYVFx5F0tOcWRc/8INz77WBCkYyOw4/TGhRQ0xT4jkZTH9lpApZK+RSNTM38EheXiXpUlA6EcvOwl+eXONy539JD4yFdh+nxR/Rdqk3p2ggNjRI37b97gnKaH/U5anbPcjvAmbXjmQno1nIiZqsnNzzfYeKkQAgpKATSr+5fB9oDXQDIGadN9mAo0hAuBmZgtw==
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>
- Delivery-date: Mon, 01 Feb 2021 15:06:57 +0000
- Ironport-sdr: D+qiPcmJdTvK/MMSKIwebaB5Am/s7qJyoundTtE7WG7qVAH1drLb3QBBg73sTlfGvP0cdI9KUl 2/v2fXWi5ZNZgAllXQ+yMOWi6ghg8jduHwYkMPjJzb/oQZM3CLgS+bR9v4+j/Yrof0pWHX1LhC XWBDR19RVKL7dPLC5/A1KEf1lQO9PRB16BSl03ZvpikBgtNsJQT/9PsFyZv5Kg8iFko16iwfnL /m2H460lM8Qnq3DHWjlt3ceaZ7vLtcFNESMm2S0oa/fGSg15m/vLsOZjPcSNAm6wHShxDESW0p mNw=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01/02/2021 14:56, Jan Beulich wrote:
> Going through an intermediate *.new file requires telling the compiler
> what the real target is, so that the inclusion of the resulting .*.d
> file will actually be useful.
>
> Fixes: 7d2d7a43d014 ("x86/build: limit rebuilding of asm-offsets.h")
> Reported-by: Julien Grall <julien@xxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, whatever the
outcome of the discussion below.
> ---
> Already on the original patch I did suggest that perhaps Arm would want
> to follow suit. So again - perhaps the rules should be unified by moving
> to common code?
>
> --- a/xen/arch/x86/Makefile
> +++ b/xen/arch/x86/Makefile
> @@ -241,7 +241,7 @@ efi/buildid.o efi/relocs-dummy.o: $(BASE
> efi/buildid.o efi/relocs-dummy.o: ;
>
> asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c
> $(BASEDIR)/include/asm-x86/asm-macros.h
> - $(CC) $(filter-out -Wa$(comma)% -flto,$(c_flags)) -S -g0 -o $@.new $<
> + $(CC) $(filter-out -Wa$(comma)% -flto,$(c_flags)) -S -g0 -o $@.new -MQ
> $@ $<
> $(call move-if-changed,$@.new,$@)
>
> asm-macros.i: CFLAGS-y += -D__ASSEMBLY__ -P
|
