[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] libs/light: make it build without setresuid()


  • To: Manuel Bouyer <bouyer@xxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Fri, 29 Jan 2021 23:05:24 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vKpbeZol6SMxiPszJgGOcP0G8cllNe+8ynG2DFmutWE=; b=gNtWYymF2jTAloaXaK54FGHNmjyrNKeZPnwTCE3x21j1ku1zUFS3IN1Oo6f4ZhEX+AQQL8xgB2iYJ9jin7taI6ygrUnwcUhYsy4hMGpKD6+XkybUtSdcfZqsZfRVM8zfIc/KysrwcfJweO/i14tWviWZFygcU2PALj5EqzFnv+tv+9DGPs+dDTfVllu2p1K1r9X/0ZiDHgbreETcteps1sdnoXQWiLJPk69Ubr6HiFHdk/wdg5LPmeFEFzqLxyJ94YiAul/I+1LjVn+VEABCHA7vZY0g7P+bjJLPOlayTF/i5KuIuRIVOTMxakUSVlhK2mxn3vANP8xb3mKwHO4gKg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lB0nEsNToeVse6sqMsdcLw648VS9fr+JJG/ricVs2VpRDuIuMzPILn8Ka2H/1GZg9EsZ1bnyqp52JTM4s+dDp9X40v68u2p2Tp//j/frOcyEgYF2T74JZDSVCCaP2R9P/KijIG9iegABlqgVR+auVc7+KDW5YOctViY9GSgajKXW2adu9Zl0tkJiXZP/yMD4SjX5UgvVwmEpgZjfzkfQPnXUKiXatn0EgIC6DCLaamFI+TjFjm2v63Mjdk1r5lvr9t/gBuzRkq4sKb35h1jqQXdezNzNeHn8XGAu6udcncFbmwq9oq+JdCH+KVTMjx2YGWiiGVvPWQsv8Yq2d+NXWA==
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Delivery-date: Fri, 29 Jan 2021 23:05:45 +0000
  • Ironport-sdr: opinFsGygOKMs5DSYkQUf4Av8hj16tJeeqcEEzSFBf501Ehc9dNeGL+iBVRclaqrLueAAawHyJ THhTFHhSFr8wTE+/wGfExpb7kVFmJYwUaZADG5ubRP2/jOoEFv0+ojgpemtphKOzd7M/9n2yqF FhJxWlh8sNF7q3e4fktpGd44KEruvbfW3MrwuaILpJEGB5KyK8JjTsiHZHKZTEUJHxWvxKkrQU eWHULtPlIhuQWuBuL+mnpfmoZmEMDJEJyFppLwiRM8gRprMedmBonKwzkXXlejH+Zy2tEEReMD XUE=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 29/01/2021 23:01, Manuel Bouyer wrote:
> On Fri, Jan 29, 2021 at 10:51:14PM +0000, Andrew Cooper wrote:
>> Given the freeze, and discussions on IRC, I have committed most of this
>> series.
> thanks
>
>> This particular patch doesn't compile, but I fixed it up.
>>
>> Still outstanding are "NetBSD: use system-provided headers", the
> I just sent a v3 of this patch

You accidentally labelled it v2, but I'm sure we can cope.

>
>> followon patches requested in "libs/light: pass some infos to qemu", and
> will try to get at it tomorow
>
>> "xenpmd.c: use dynamic allocation" which failed like this:
>>
>> https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/996140268
> It looks like I don't have access to this page, could you share the
> content ?

urgh - have the permissions broken themselves again...

xenpmd.c:115:13: error: implicit declaration of function 'asprintf'
[-Werror=implicit-function-declaration]

It needs an include of stdio.h, and/or some form of #define _GNU_SOURCE.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.