RE: [PATCH] xen/memory: Reject out-of-range resource 'frame' values

[Paul Durrant <xadimgnik@xxxxxxxxx>]

> -----Original Message-----
> From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Sent: 28 January 2021 16:06
> To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>; Jan Beulich 
> <JBeulich@xxxxxxxx>; Roger Pau Monné
> <roger.pau@xxxxxxxxxx>; Wei Liu <wl@xxxxxxx>; Stefano Stabellini 
> <sstabellini@xxxxxxxxxx>; Julien
> Grall <julien@xxxxxxx>; Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>; Paul 
> Durrant <paul@xxxxxxx>;
> Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> Subject: [PATCH] xen/memory: Reject out-of-range resource 'frame' values
> 
> The ABI is unfortunate, and frame being 64 bits leads to all kinds of problems
> performing correct overflow checks.
> 
> Furthermore, the mixed use of unsigned int and unsigned long in the call tree
> is buggy on arm32 where the two are the same size, and certain out-of-range
> combinations will truncated and be permitted.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> CC: Julien Grall <julien@xxxxxxx>
> CC: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
> CC: Paul Durrant <paul@xxxxxxx>
> CC: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> 
> Posted ahead of my full v8 series, in the hope that it catches some people
> before the end of the day.

Reviewed-by: Paul Durrant <paul@xxxxxxx>