[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v10 05/11] common/domain: add a domain context record for shared_info...


  • To: Paul Durrant <paul@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Mon, 25 Jan 2021 19:11:01 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6QUAOw31YyV1vKvMnvkcT6FgfD3T/lkhQbFGYsLrHGM=; b=Oj3FW9OnXvwyxbehcwVvUyoEZYph7NN0X3wYneqQo8c8EtzuCswEym52xZnaeypRAXF/H2N88YWoUkry/v+Mlykg1aUl1xW6qzLT0llEcU7z1buON/9B04MpYMnsZYi37QbSf8rta3ntE7kbMNvs41LmMajdBhi7ITl75tZE/7+xAiShIdweQFiVY+VmrAZHFhSc4BiY/hKESdufG833ERSMOekDsmuFsauN81Tq7MoHPPC/qldnTLs9DiENJ6CQ7TieUS1bzLj+Oxrf/164A7hXIvvjk1tSJZ3V6DPcgCi6jhCWKoWW/Fq/fs2zvQn/P6daPEoCQEUdasJOW0d9Gw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dAAc8W2ZoAtOjPRwqFPKXisliyL7/a3uwk4RLP8edyX709UUODBRiQV9FFZEOXpZ5ZIH633T/KfZeproUbN/G7Vdi+A9i7nZSUu208H6SLQEQzWPh1DFJsR1aZE+2s8rDoBVXxP0uAlyfYrk9POWB7IEqmjMWBcphUk8vDl/hb8UMk7FIZpdGWjn9yJwWMhSry5bbI5R22SrfW0dKn9UfZJW6XdO2O/isqA4pWTtRY3tyyMWNPi+QUx4OqqCciUTzJ2TwsJHHgVfTusAfkfiNfrgTTGjIYjQkvrVTiKhEh85tGKqg8uEHSePt6Vg2YqJQ4xWqjyyrs//RF6VyPsuiA==
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Paul Durrant <pdurrant@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • Delivery-date: Mon, 25 Jan 2021 19:20:06 +0000
  • Ironport-sdr: BWGP3Smq33DlwPUp3/vqeoxVdI14ToXfBd6+F9kvU7iJQrSUqRGh8Y2oiuGDhXADb+poiUmpB+ 4VcYB7UPy46SZvAsTJuKvZELhsPhfOrr5zjR6VluFzHxX+rJH7pIsxCjFww2kELDjUKHPH2qTL kOsccdWf/J2594aLg6+9JFtAYmol7/XfI6wH82kuZDqfJvmvMrBFOo29tZjo2mM9GDcGmd7VFr QcfsWFhhU8YHMtcX6vyC1ZV5IpXYk+85jKMPwmbYj6a+X7E0a/muNi+OhQOA9dpJqBd8WPohZq YFU=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 08/10/2020 19:57, Paul Durrant wrote:
> diff --git a/xen/include/public/save.h b/xen/include/public/save.h
> index c4be9f570c..bccbaadd0b 100644
> --- a/xen/include/public/save.h
> +++ b/xen/include/public/save.h
> @@ -58,6 +59,16 @@ struct domain_context_start {
>      uint32_t xen_major, xen_minor;
>  };
>  
> +struct domain_context_shared_info {
> +    uint32_t flags;
> +
> +#define _DOMAIN_CONTEXT_32BIT_SHARED_INFO 0
> +#define DOMAIN_CONTEXT_32BIT_SHARED_INFO \
> +    (1U << _DOMAIN_CONTEXT_32BIT_SHARED_INFO)

There is no need for the logarithm version of this constant.

You do however want an explicit uint32_t _rsvd; so buffer[] doesn't
start at the wrong alignment for an efficient memcpy() in 64bit builds
of Xen.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.