[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: Fix compilation error when early printk is enabled
- To: Michal Orzel <Michal.Orzel@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Thu, 21 Jan 2021 09:47:05 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cA4uZRpU49nu4ac35BYxCHWMCtffTLDf4gTZBenWqPM=; b=Vw9Z4EhpBQJDsK9FnlxFnj01cmqHdecOK8sgMb/PnyfrP2MiWCp6CyP/LyaW/JSmWZQzDELHYELeirxG3mCKcpDSzM1OmYLO6uohIp0P9aQo0Q/y9Rfua0zzNhafej1PUhPHi/KS1vpLd9AfizXwS8TkTvgZ8EsWTlnNlKX+fq+lftSlP58OGkKbV0r7llA2ZlTeZVUt+n/FZMtTUEvb5yLi0fBLayUhQMxrBOBMFxcje+Zto4Fzh0Qx5TECSJ1AIAlLzrPsmaUtjo07YJGtqECGVmY2kcUCnMQm10citKIr4uxspZ7CKrLE3SYFjB0W+hTbqg5vyFtVE09rF2yn/Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=joWYvcKdbMMy/+skKu//B5Ij1y9xezeR7Ul5BpeppTMVpaUa7X5hkX6zYLP8bwHRI/H4ZqCKKX221kxMHiYRcVjaTLmAY0ecX/OnKU3jTniKBdktaYGa6ry/nlmY+icqyYX3MvyEhWzpsTBp4h6LNNTcC+Gh2dguPL2bdX+05uhStGkooI82/X92ikt1Y3LALwYk1XrO2vCwp92pBWzdQ2HPuDg0ddPUaLYCrG7alv48l2eG4iNrQEJ39dxKFyBHIfCRrs1Ijb1p7cBcJxGU0g4pIpw/6bJL659NxYJmSEbWYIHv3iY5zvIP/bqTZsJSWnRGnNld2f37l1riWtou3w==
- Authentication-results-original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>
- Delivery-date: Thu, 21 Jan 2021 09:47:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHW79gjfjfuQDx1Nkaed0nd13wr0aox1Q4A
- Thread-topic: [PATCH] xen/arm: Fix compilation error when early printk is enabled
Hi Michal,
> On 21 Jan 2021, at 09:30, Michal Orzel <Michal.Orzel@xxxxxxx> wrote:
>
> Fix compilation error when enabling early printk, introduced
> by commit aa4b9d1ee6538b5cbe218d4d3fcdf9548130a063:
> ```
> debug.S: Assembler messages:
> debug.S:31: Error: constant expression expected at operand 2 -- `ldr
> x15,=((0x00400000+(0)*PAGE_SIZE)+(0x1c090000&~PAGE_MASK))`
> debug.S:38: Error: constant expression expected at operand 2 -- `ldr
> x15,=((0x00400000+(0)*PAGE_SIZE)+(0x1c090000&~PAGE_MASK))`
> ```
>
> The fix is to include header <xen/page-size.h> which now contains
> definitions for page/size/mask etc.
>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Thanks a lot, this is fixing the compilation issues.
Cheers
Bertrand
> ---
> xen/include/asm-arm/early_printk.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/xen/include/asm-arm/early_printk.h
> b/xen/include/asm-arm/early_printk.h
> index d5485decfa..8dc911cf48 100644
> --- a/xen/include/asm-arm/early_printk.h
> +++ b/xen/include/asm-arm/early_printk.h
> @@ -10,6 +10,7 @@
> #ifndef __ARM_EARLY_PRINTK_H__
> #define __ARM_EARLY_PRINTK_H__
>
> +#include <xen/page-size.h>
>
> #ifdef CONFIG_EARLY_PRINTK
>
> --
> 2.29.0
>
|
