[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] x86/smpboot: Re-position the call to tboot_wake_ap()
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 19 Jan 2021 15:38:14 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FG46/5jfbqtW7jdeIaBcf2b6zG+35QeJUJ8B67129j0=; b=gQbOzT+NnxDJ4NsJu2KmJ2jHS0ndQAjrDP0JWBAzZ3kEC5HzrfELfVMos3b/F77evIr38NKFV7x5arQclT3q26P5Z3lwghOXsdqbrNZyqP/ttzuG/xsWgp916rl51ufNovcMmvoNvuE+Mcmu1lz0e6FXTf9Y/W8hrqsgKK0Cu3Lk3Sj6442/302o82NsTE1/li/vbyMa9ndROa4iwiRUOjU6rH21HeqLcchw4/3xdVDlc7YB5ZKLSfxnEZQbf+F/ovE9byKZOev3NL6ZhfdcLLaqUcBk9KtzLmmALy/vrYaz53UwvXgpYVeYY5649I8YRVBYT2AFrlibAowhwOkXAA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eSRB+QBup0iujWehQxAfhE8zO8/9AMd4aWwwLVDPaJ2kD533p0mcBjkh3LOJEBuV4wsDCTvzCGWTdCc7iIVm/tpHKveyvG4mntFZrEpDwR+d/E/gyrrWDNRIPYAw955wR4Oa0NaNlA3SGi9VxmF1EVJB6j77+yBy556ms5rFHPwMTiFWNjAYPjJRHvPMNUyNaWRAEuIZF1W1TDqwvHmJhq2X84D44WWXDWMUNnghmTxh8sAqz/LdBcme9gHaLwZY0yzpOyaHhNdSA78sIGV4cRow5EuK5A9PM8kHqBKuH/A6Y1Ok1CBhvPdYaMOTs9KM8QfmKIvYx/Eb3kM6mVhHGA==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Marek Kasiewicz <marek.kasiewicz@xxxxxxxxx>, Norbert Kamiński <norbert.kaminski@xxxxxxxxx>, Michal Zygowski <michal.zygowski@xxxxxxxxx>, Piotr Krol <piotr.krol@xxxxxxxx>, Krystian Hebel <krystian.hebel@xxxxxxxxx>, "Daniel P . Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Rich Persaud <persaur@xxxxxxxxx>, Christopher Clark <christopher.w.clark@xxxxxxxxx>
- Delivery-date: Tue, 19 Jan 2021 14:38:43 +0000
- Ironport-sdr: NSQ9gwJn7Xz3scB1NEjCyYLhIriraIYxVg6SaV4x0FyW0FmEILJFuww3h9p6jIy3mcP8ewoL34 HTisXtCo3wsxC6Ics9+xLe/QHpQPdQUBQXpHBFeq4zOiGMZ2MZujgC1n2tl9p/xJbeyqxuiNTl bi3tVy0QEKllmw21gzAUNpoweI2pQoEzrSRg9B/tyGS5e/mgO22mg1cKYDZOJkWM78mqfAeeDj a7EBYn6rrXXH6YIMVfBP8hbhRqq28+IIxfpMKuHZtfHYqbVttNsn3+kAqzDdne//Nlxv6ouZgh vIs=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Jan 15, 2021 at 11:10:44PM +0000, Andrew Cooper wrote:
> So all the moving parts are in one function.
>
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
> CC: Marek Kasiewicz <marek.kasiewicz@xxxxxxxxx>
> CC: Norbert Kamiński <norbert.kaminski@xxxxxxxxx>
> CC: Michal Zygowski <michal.zygowski@xxxxxxxxx>
> CC: Piotr Krol <piotr.krol@xxxxxxxx>
> CC: Krystian Hebel <krystian.hebel@xxxxxxxxx>
> CC: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
> CC: Rich Persaud <persaur@xxxxxxxxx>
> CC: Christopher Clark <christopher.w.clark@xxxxxxxxx>
> ---
> xen/arch/x86/smpboot.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c
> index 67e727cebd..9eca452ce1 100644
> --- a/xen/arch/x86/smpboot.c
> +++ b/xen/arch/x86/smpboot.c
> @@ -426,6 +426,13 @@ static int wakeup_secondary_cpu(int phys_apicid,
> unsigned long start_eip)
> int maxlvt, timeout, i;
>
> /*
> + * Some versions of tboot might be able to handle the entire wake
> sequence
> + * on our behalf.
> + */
> + if ( tboot_in_measured_env() && tboot_wake_ap(phys_apicid, start_eip) )
I think you are missing a ! in front of tboot_wake_ap?
Thanks, Roger.
|
