[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/acpi: remove dead code
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Mon, 11 Jan 2021 18:02:37 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OMhNtnm/uG+VzLiuXgYasmudyTZnL5bJ1zRba/XTqDk=; b=k3rZQ7BCh8P/s+2FlXSzjUhDpOHv2Wc509kwS5y3H4J14gfKTaW2I8LnOkyX3daZVoRfcuaw9QZu/Xta0jgDLIncsAU9SmR6sZhAGm7Re3ubU0smZbquclXRO4i2qGK41vpWUdZI4fZ7VqXrYG7EYuHVQ80UxOIM2QeOU946B7VTCXd2dfgpZkdXZgXDdLwHIaaDjXu6VeR+dO3FVlvNsOII1ZSrzjYZAEo3YwpbX+9m4t/ww3ZaEA1JuWpgcVInBlqn96BqjWiDnVYCgqutxPM67A1qgtk4prAQhO4bvJ8h+BogH/prisWJBQUqdxhXaLuC8ZM+Plq0vgJA2soB1g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ed8Pq2T2EUbuROyJUwJDszmrcdprO4SLhkpqvhpFF5qN6waHcwcyEQYNqIwLrBtMqISt24pj604LTiPcPYh8tmRL2KQQqFZJkHaDBz1l6H3mlP3JsWaeA1flkPSeGYL3kZmUhEkF0HSvWQWA2F3VVAe22pSh5BBJm4OhlFF77CYzaaN1u98lwnyaT2jBGklJ4lgaFVzZ/HQ858OVz3oQ0LOWI8HqsCGL7ISBKlWjigFDmu4X3ieZRp+1FqXvcyglbYliSRCnUWYsmM/a5DBMbWCbsbAnxOjKkeiE2al8YNB56rGPnrjIeLrrTkUsKQqUpwu9xNhoeqRMpXh8MyhdOA==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 11 Jan 2021 17:02:53 +0000
- Ironport-sdr: A/YMFE9/M69Toje/uB10rFivlS39IivDA4PidCRiTwijc/OjMMGoyUhksfBgLmZ6u/gEoxXlHH epMtw3CKAI2M7FTFze6h8cVJHRgeIp9M2TQbFFPQHP+w/Qad7CfTVjD/ZRnSszwiNFZQma4M9l 62R5p2mVDO45YUeYD2Lkset4yzbtZLLnYVyyXDVKeSroIyZ6bNPYLruZ4xczVgaQqqNHermasZ znQDzF1RUPPhnRDZCA5J4EvehAKxYqMchjOcqT5L6rG9fMw/X2AW2qF26m2id3Re4cG0WodGVJ uJs=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Jan 11, 2021 at 10:33:28AM +0100, Jan Beulich wrote:
> On 11.01.2021 10:26, Roger Pau Monne wrote:
> > After the recent changes to acpi_fadt_parse_sleep_info the bad label
> > can never be called with facs mapped, and hence the unmap can be
> > removed.
> >
> > Additionally remove the whole label, since it was used by a
> > single caller. Move the relevant code from the label.
> >
> > No functional change intended.
> >
> > CID: 1471722
> > Fixes: 16ca5b3f873 ('x86/ACPI: don't invalidate S5 data when S3 wakeup
> > vector cannot be determined')
>
> I kind of consider a "Fixes:" tag contrary to "No functional change
> intended", but I guess Coverity considering this an issue warrants
> the tag at least in a way.
I've just added the tag so that if the original patch was backported
this was also, in order to prevent Coverity complaining again.
Thanks, Roger.
|
