[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] xen: remove the usage of the P ar option


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • Date: Wed, 30 Dec 2020 18:34:46 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5rD97J0qexyqUc5qGNFGzyy8YntChTzAmA5ZqLrTlyQ=; b=Mn1uw6z95eKzCJJu8z6XTGr0se+x7QY0Cde8tBzzcIlA6xQ6HjHjnaGXaPIUysoNV2q8NDS9x3YMvZjTC90aI3lepuA0V4DnnV1etjwheU7Clxy0kt7Ozn3MXwmt4KWsMQEo+J8T5GdioafN+UIh6AmWRY7BocW1Cs+OwTvppk8v+sAKMYdNwp7NXwZWdPuAVzNiaF39ZR1CMW380Kay0j/ZO6npOojRD+UABBHVi9neQ8wbLwLtFta65In6CrZKlDoTowGWnSBFL8aTECXQAKEYpotlFcFl4oDIJMw0i7g144QY35+ZooTv7EskC8he4z0cbsFG9p0qhx+PGzViug==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MRXBLbGzadKYv2x1D9smHgeef8YB3zw8eqSUS97J/UYHpygWbsl8twyX02KuxT77Tuaw2U2jJx2ltxxMn1i7ylwef4dmk/2JT7GV+3hPJ2eQb6Svy29AhyjhMgnFd9KguCLLASJhrftSzDbUQCarsRSDnTn01JZG6QvhSrgXXEM+sFvyDgF2WbwFsClXT8EN8B5R6qne0u+CQCIYG5CMCaRnLXeyropsupNiy5P0iTjLJrhHDrspXF9xoeePQHFce0cieu2m3tI2Dl09d6ybQrHyHSTcC9f3iNwIR+EW3ikaQVO7Z3yKY+6Nxhe11rmBAdx38lzMiylUG371JtjGtg==
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, "Ian Jackson" <iwj@xxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Wed, 30 Dec 2020 17:35:06 +0000
  • Ironport-sdr: g4SHdFR1EJYBKynpKjircudJ3rxNuCC6XtfFi4L7+ZJ0w1U6P2F27r6jJDRSm8g572rmH2IPG0 lfiOxwQTfqT+/ewMaBXOG+I53tUeCEEkPF0Orfrwa26MN5Li37RDXYTwG2lVy6AfR8TI+TBTbq PGLkhBJIx9KkXuu+4x5wMyyzCE+pxUePIwRLRimdipf3aM00N8DXYApOAnHHRQd3wW8RBF5J9N XXaHlql/UjZkamxKzjyyl/5+F6NYoLnBFqyjCNdEFyG6PEU2Px5UJpU6diZeeB5R2zbAwaUYiH r3E=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

It's not part of the POSIX standard [0] and as such non GNU ar
implementations don't usually have it.

It's not relevant for the use case here anyway, as the archive file is
recreated every time due to the rm invocation before the ar call. No
file name matching should happen so matching using the full path name
or a relative one should yield the same result.

This fixes the build on FreeBSD.

Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

[0] https://pubs.opengroup.org/onlinepubs/9699919799/utilities/ar.html
---
I'm unsure whether the r and s options are also needed, since they
seem to only be relevant when updating a library, and Xen build system
always removes the old library prior to any ar call.
---
 xen/Rules.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/Rules.mk b/xen/Rules.mk
index aba6ca2a90..8fcffffc98 100644
--- a/xen/Rules.mk
+++ b/xen/Rules.mk
@@ -71,7 +71,7 @@ cmd_ld = $(LD) $(XEN_LDFLAGS) -r -o $@ $(filter-out 
%.a,$(real-prereqs)) \
 # ---------------------------------------------------------------------------
 
 quiet_cmd_ar = AR      $@
-cmd_ar = rm -f $@; $(AR) cPrs $@ $(real-prereqs)
+cmd_ar = rm -f $@; $(AR) crs $@ $(real-prereqs)
 
 # Objcopy
 # ---------------------------------------------------------------------------
-- 
2.29.2




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.