[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/5] x86/build: limit #include-ing by asm-offsets.c
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Mon, 28 Dec 2020 13:54:42 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TDmlxzDJ5JztCfIVcp+wiQjgcvygoqzWp44y+GA9iDw=; b=QRl0d/y4MWl/aFXqgZUhINwZqAmdWZtYjmFbleSy/toHLV/pl5/oAkAbivf/zfPBJOOymiNELdAvPTJNDRJdMe7X01kjtAG5rVoClcOxvqvXu+6SPd3rorBPisudaLD8BhU4WLvQfSgkY4n0I3BeCtc8MbpNa1JQCs6jPFUaIOPkgmnxjE7tGCmI7IMcX3VCfQnxfUzXFx60WgMOUDrZy7jQbz0VI4oEBbNWhAfvcSJw0vNhsLyADaC66lHzYvlc0/OBgYAD40lAh/zqx7KsxGJT7q8/mtZe3KY5u0of0cNlRFQuB0/IIscrA/GIVEQW8Dw1owptfz3PHj3CfSoG+g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OsB+cznp6Rv20kCPQLvF7HZry7onZwGUiGiBYPjbWrTKvtIgq5MqxKoqXkWDvX1KuT75qYwSvNAAPliF+8M2a8RVDJj5i8eCOTp8ln9e3thGs1MRBZ3pk4LxCIEZ9nugoUjUPCCjMhzN+cQIJd8rUP+QCYf3WgdKmei5sQZDj4GzjfqYIUujXOmXfBHBrWDiZEkv1xyfzLNLoOnaWgszwrizEn/KftMGCgVTojjDt2XgG6wiq3atnF+k/ESMOtthgH0/u3wqmE6IwjjgBJLDf2gFKL04uqffJDHV8ASQ4FBrD9nJyK9g0LYiEQCvCHq7AKkzTGdtQ35YSrgJ75n70w==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Mon, 28 Dec 2020 12:55:02 +0000
- Ironport-sdr: F4RSj03QukSpBuFbVzBB4/5j6zndoGedE8b2ZOBzOwWX+nKeMs5BhFC9SxMowXi1C0FU99PIUn L4HTPBXJt3gnCD6QUTy1DrZgG+RHQGlZ6zGIGxuEefmBBaNluVe43J2UOuESIu/2m2ORc5bheE lpKC6nKHPdV3uGm7EgSCAlUmwg67zIZWvZT1JHu/tz33FJ5pYN/jbVWhSurFQ6VZxfr7NkgyJT AVXdKJ5ozL7f42+2+lVY8TYyoNu4gFWSis4jOt4fELcNqix7luhytBOYMVoahtV5Iwe271CzHC iSs=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Nov 25, 2020 at 09:49:21AM +0100, Jan Beulich wrote:
> This file has a long dependencies list and asm-offsets.h, generated from
> it, has a long list of dependents. IOW if any of the former changes, all
> of the latter will be rebuilt, even if there's no actual change to the
> generated file. Therefore avoid including headers we don't actually need
> (generally or configuration dependent).
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> --- a/xen/arch/x86/x86_64/asm-offsets.c
> +++ b/xen/arch/x86/x86_64/asm-offsets.c
> @@ -5,11 +5,13 @@
> */
> #define COMPILE_OFFSETS
>
> +#ifdef CONFIG_PERF_COUNTERS
> #include <xen/perfc.h>
> +#endif
> #include <xen/sched.h>
> -#include <xen/bitops.h>
> +#ifdef CONFIG_PV
> #include <compat/xen.h>
> -#include <asm/fixmap.h>
> +#endif
> #include <asm/hardirq.h>
> #include <xen/multiboot.h>
> #include <xen/multiboot2.h>
> @@ -101,7 +103,6 @@ void __dummy__(void)
> #ifdef CONFIG_PV
> OFFSET(DOMAIN_is_32bit_pv, struct domain, arch.pv.is_32bit);
> BLANK();
> -#endif
>
> OFFSET(VCPUINFO_upcall_pending, struct vcpu_info, evtchn_upcall_pending);
> OFFSET(VCPUINFO_upcall_mask, struct vcpu_info, evtchn_upcall_mask);
> @@ -110,6 +111,7 @@ void __dummy__(void)
> OFFSET(COMPAT_VCPUINFO_upcall_pending, struct compat_vcpu_info,
> evtchn_upcall_pending);
> OFFSET(COMPAT_VCPUINFO_upcall_mask, struct compat_vcpu_info,
> evtchn_upcall_mask);
> BLANK();
> +#endif
Since you are playing with this, the TRAPINFO/TRAPBOUNCE also seem
like ones to gate with CONFIG_PV. And the VCPU_svm/vmx could be gated
on CONFIG_HVM AFAICT?
Thanks, Roger.
|
