Re: [PATCH v2] xen: Rework WARN_ON() to return whether a warning was triggered

[Jan Beulich <jbeulich@xxxxxxxx>]

On 18.12.2020 14:30, Julien Grall wrote:
> From: Julien Grall <jgrall@xxxxxxxxxx>
> 
> So far, our implementation of WARN_ON() cannot be used in the following
> situation:
> 
> if ( WARN_ON() )
>     ...
> 
> This is because WARN_ON() doesn't return whether a warning has been
> triggered. Such construciton can be handy if you want to print more
> information and also dump the stack trace.
> 
> Therefore, rework the WARN_ON() implementation to return whether a
> warning was triggered. The idea was borrowed from Linux
> 
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>

In particular to clarify my prior concerns have been addressed:

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan