RE: [PATCH v4 23/32] qdev: Move dev->realized check to qdev_property_set()

[Paul Durrant <xadimgnik@xxxxxxxxx>]

> -----Original Message-----
> From: Eduardo Habkost <ehabkost@xxxxxxxxxx>
> Sent: 11 December 2020 22:05
> To: qemu-devel@xxxxxxxxxx
> Cc: Markus Armbruster <armbru@xxxxxxxxxx>; Igor Mammedov 
> <imammedo@xxxxxxxxxx>; Stefan Berger
> <stefanb@xxxxxxxxxxxxx>; Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>; 
> Daniel P. Berrange
> <berrange@xxxxxxxxxx>; Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>; John Snow 
> <jsnow@xxxxxxxxxx>; Kevin
> Wolf <kwolf@xxxxxxxxxx>; Eric Blake <eblake@xxxxxxxxxx>; Paolo Bonzini 
> <pbonzini@xxxxxxxxxx>; Stefan
> Berger <stefanb@xxxxxxxxxxxxxxxxxx>; Stefano Stabellini 
> <sstabellini@xxxxxxxxxx>; Anthony Perard
> <anthony.perard@xxxxxxxxxx>; Paul Durrant <paul@xxxxxxx>; Max Reitz 
> <mreitz@xxxxxxxxxx>; Cornelia Huck
> <cohuck@xxxxxxxxxx>; Halil Pasic <pasic@xxxxxxxxxxxxx>; Christian Borntraeger
> <borntraeger@xxxxxxxxxx>; Richard Henderson <rth@xxxxxxxxxxx>; David 
> Hildenbrand <david@xxxxxxxxxx>;
> Thomas Huth <thuth@xxxxxxxxxx>; Matthew Rosato <mjrosato@xxxxxxxxxxxxx>; Alex 
> Williamson
> <alex.williamson@xxxxxxxxxx>; Mark Cave-Ayland 
> <mark.cave-ayland@xxxxxxxxxxxx>; Artyom Tarasenko
> <atar4qemu@xxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx; qemu-block@xxxxxxxxxx; 
> qemu-s390x@xxxxxxxxxx
> Subject: [PATCH v4 23/32] qdev: Move dev->realized check to 
> qdev_property_set()
> 
> Every single qdev property setter function manually checks
> dev->realized.  We can just check dev->realized inside
> qdev_property_set() instead.
> 
> The check is being added as a separate function
> (qdev_prop_allow_set()) because it will become a callback later.
> 
> Reviewed-by: Stefan Berger <stefanb@xxxxxxxxxxxxx>
> Signed-off-by: Eduardo Habkost <ehabkost@xxxxxxxxxx>

Xen parts...

Acked-by: Paul Durrant <paul@xxxxxxx>