[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch 20/30] net/mlx4: Replace irq_to_desc() abuse





On 12/10/2020 9:25 PM, Thomas Gleixner wrote:
No driver has any business with the internals of an interrupt
descriptor. Storing a pointer to it just to use yet another helper at the
actual usage site to retrieve the affinity mask is creative at best. Just
because C does not allow encapsulation does not mean that the kernel has no
limits.

Retrieve a pointer to the affinity mask itself and use that. It's still
using an interface which is usually not for random drivers, but definitely
less hideous than the previous hack.

Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: Tariq Toukan <tariqt@xxxxxxxxxx>
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
Cc: netdev@xxxxxxxxxxxxxxx
Cc: linux-rdma@xxxxxxxxxxxxxxx
---
  drivers/net/ethernet/mellanox/mlx4/en_cq.c   |    8 +++-----
  drivers/net/ethernet/mellanox/mlx4/en_rx.c   |    6 +-----
  drivers/net/ethernet/mellanox/mlx4/mlx4_en.h |    3 ++-
  3 files changed, 6 insertions(+), 11 deletions(-)


Reviewed-by: Tariq Toukan <tariqt@xxxxxxxxxx>

Thanks for your patch.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.