[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 0/8] xen: beginnings of moving library-like code into an archive
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 9 Dec 2020 11:33:47 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EnuAxnuXMlv2SnleMKIqhOaNxzyLAcdqVkNdCcd9Qwo=; b=Fdj2kaz+52+uX6CmNpc/ih1oJFwNyvKOszLCOVYI8R1BJwp2IKJ7IxGFBo/ZBfRefUt/KjefrHfktEY4WU8vjYWgtRIpu6jAnNU0wMEzGcb6fid5f5b2MEDhuaMVY1QuVYe4rP3UV9sXaMbWp6sJ2GOa8DCAHjwjWoRZn/vE15b8JOGGV/6FTJp7ShZlhLmNCjGuP1AhTv7gbpd/65n47x17pwUZLQRKUq/LApvAVCDAAOycFvu3fUwTQL1qsjC34NOmkmsJ4N4SSI1TFVSN116F2QuTdSZeh5MDoJNESmIkcgSen9ejYmKZmMjENKMf46/8uuKOVU5lya6CoJIKGw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jgXYigpARm0z45LWPuzSWTnEcS8NHiqbhIV04qaWfA1WTsZhptEvuGGihYobYvkUKvJUDou517cjqE4SZyZwyx5Okz7Q9JXTCfz+iv2b8NuP3znMI3B2RtT8SMZkfs1ZqRkaNlEG1c2xKscy/EzS+tDjb4grcgNTmHcdDaIr2VKpfvbRQ86JyvWcaUZu8xUGNo8iL6V8TGOoeDryqlgtu2EGJKSw9bCEe/4BwqLXoHHKHlcfTdtnNufbRxBXzEgVE+ES64GJBaWDCtV7UfgISOkQOatxJCDyioA3MHUarUvg7FcMuY5S8/m3k1aX56tQyLADOHI6DXqYXcUR0Xf3JA==
- Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
- Delivery-date: Wed, 09 Dec 2020 11:34:07 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHWwaul6ZNQ27c670WmXpdnGV75B6nuuvgA
- Thread-topic: [PATCH v3 0/8] xen: beginnings of moving library-like code into an archive
Hi Jan,
I will review this today, sorry for the delay.
Regards
Bertrand
> On 23 Nov 2020, at 15:16, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> In a few cases we link in library-like functions when they're not
> actually needed. While we could use Kconfig options for each one
> of them, I think the better approach for such generic code is to
> build it always (thus making sure a build issue can't be introduced
> for these in any however exotic configuration) and then put it into
> an archive, for the linker to pick up as needed. The series here
> presents a first few tiny steps towards such a goal.
>
> Note that we can't use thin archives yet, due to our tool chain
> (binutils) baseline being too low.
>
> Further almost immediate steps I'd like to take if the approach
> meets no opposition are
> - split and move the rest of common/lib.c,
> - split and move common/string.c, dropping the need for all the
> __HAVE_ARCH_* (implying possible per-arch archives then need to
> be specified ahead of lib/lib.a on the linker command lines),
> - move common/libelf/ and common/libfdt/.
>
> v3 has a new 1st patch and some review feedback addressed. See
> individual patches.
>
> 1: xen: fix build when $(obj-y) consists of just blanks
> 2: lib: collect library files in an archive
> 3: lib: move list sorting code
> 4: lib: move parse_size_and_unit()
> 5: lib: move init_constructors()
> 6: lib: move rbtree code
> 7: lib: move bsearch code
> 8: lib: move sort code
>
> Jan
>
|
