[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH V3 20/23] xen/ioreq: Make x86's send_invalidate_req() common



On 08.12.2020 17:49, Oleksandr wrote:
> On 08.12.20 17:24, Jan Beulich wrote:
>> On 30.11.2020 11:31, Oleksandr Tyshchenko wrote:
>>> --- a/xen/include/xen/sched.h
>>> +++ b/xen/include/xen/sched.h
>>> @@ -552,6 +552,8 @@ struct domain
>>>           struct ioreq_server     *server[MAX_NR_IOREQ_SERVERS];
>>>           unsigned int            nr_servers;
>>>       } ioreq_server;
>>> +
>>> +    bool mapcache_invalidate;
>>>   #endif
>>>   };
>> While I can see reasons to put this inside the #ifdef here, I
>> would suspect putting it in the hole next to the group of 5
>> bools further up would be more efficient.
> 
> ok, will put (although it will increase the number of #ifdef)

I was implying no #ifdef in this case, suitably justified by half
a sentence in the patch description.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.