[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/7] xen/arm: create a cpuinfo structure for guest


  • To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Mon, 7 Dec 2020 17:24:18 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WlH+Sxi4vEnksM6T974PSKhfPj8eLEJTs61bgnI4m5U=; b=iXSTeiw2kZBllqvCSA9PxoR+IMljBQ0m/J/C2fvNbAze8wD0ERgUop0S3GSlzZxZWuTI9rju6t4bXPJy8gGh4oQmY9R5v6iDQHJ61Ms/aPtnpbKdAVNL67NgO3EjZ0aTDsB8+Kyq8jsPzcXdsne//UniB6rS0E5UOKt8u67qQCsSqJYvpUQGfu+wkKQAPZZfn+fuVgrpZ1z7OWkKrbmAhSm+jxxUwbuHRIbcanTttIotGxBgU0dS2yBG+/WaS0hDjQ62yyeUw2p4sR1AS20WKmDr3sKUokg2RvHUezwLGfR3XTAkVkpJwJjU92DhnSajZCbg6d5RrPGp4P7WGAZ0wg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aIfwE7lnH4FQOsYwNdD9ekj0jbCZp379ZrvcBe9TMO1YKhGVIi7dHNRa2f6Rm00zZMqm07+lds5lDYpnEbO8wf4tWIGg7HnMGz9S4CNHUitdWIZDYUpMgrGAaEfx0RmTvn0rnlap0//j6gzTODZ8IjVtPF73rZwV7JzTlTcnQ5HchLn7YfBfcHocFa9rLrVgvihUG+RRHxabiwKSSU5SssxHYlLNYpBtpz50hqP+eZGBfJPiqMJC1aoGUr7UmJfq9rI8X5MsSNmim8RgJZmggtgEIB83Kx0TWJAO8qivJsXbxZBSqtJUbCe9EPDMElDMztqycgCB+CFyegR24xm4yA==
  • Authentication-results-original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Mon, 07 Dec 2020 17:25:04 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHWxyRpRLPV3+rSX0iDOmZYGXBVV6nnpDEAgARJGoA=
  • Thread-topic: [PATCH v2 3/7] xen/arm: create a cpuinfo structure for guest

Hi Stefano,

> On 4 Dec 2020, at 23:57, Stefano Stabellini <sstabellini@xxxxxxxxxx> wrote:
> 
> On Mon, 30 Nov 2020, Bertrand Marquis wrote:
>> Create a cpuinfo structure for guest and mask into it the features that
>> we do not support in Xen or that we do not want to publish to guests.
>> 
>> Modify some values in the cpuinfo structure for guests to mask some
>> features which we do not want to allow to guests (like AMU) or we do not
>> support (like SVE).
> 
> The first two sentences seem to say the same thing in two different
> ways.
> 
> 
>> The code is trying to group together registers modifications for the
>> same feature to be able in the long term to easily enable/disable a
>> feature depending on user parameters or add other registers modification
>> in the same place (like enabling/disabling HCR bits).
>> 
>> Signed-off-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>> ---
>> Changes in V2: rebase
>> ---
>> xen/arch/arm/cpufeature.c        | 51 ++++++++++++++++++++++++++++++++
>> xen/include/asm-arm/cpufeature.h |  2 ++
>> 2 files changed, 53 insertions(+)
>> 
>> diff --git a/xen/arch/arm/cpufeature.c b/xen/arch/arm/cpufeature.c
>> index 204be9b084..309941ff37 100644
>> --- a/xen/arch/arm/cpufeature.c
>> +++ b/xen/arch/arm/cpufeature.c
>> @@ -24,6 +24,8 @@
>> 
>> DECLARE_BITMAP(cpu_hwcaps, ARM_NCAPS);
>> 
>> +struct cpuinfo_arm __read_mostly guest_cpuinfo;
>> +
>> void update_cpu_capabilities(const struct arm_cpu_capabilities *caps,
>>                              const char *info)
>> {
>> @@ -156,6 +158,55 @@ void identify_cpu(struct cpuinfo_arm *c)
>> #endif
>> }
>> 
>> +/*
>> + * This function is creating a cpuinfo structure with values modified to 
>> mask
>> + * all cpu features that should not be published to guest.
>> + * The created structure is then used to provide ID registers values to 
>> guests.
>> + */
>> +static int __init create_guest_cpuinfo(void)
>> +{
>> +    /*
>> +     * TODO: The code is currently using only the features detected on the 
>> boot
>> +     * core. In the long term we should try to compute values containing 
>> only
>> +     * features supported by all cores.
>> +     */
>> +    identify_cpu(&guest_cpuinfo);
> 
> Given that we already have boot_cpu_data and current_cpu_data, which
> should be already initialized at this point, we could simply:
> 
>  guest_cpuinfo = current_cpu_data;
> 
> or
> 
>  guest_cpuinfo = boot_cpu_data;
> 
> ?

Ack, I will do that.

Cheers
Bertrand

> 
> 
>> +#ifdef CONFIG_ARM_64
>> +    /* Disable MPAM as xen does not support it */
>> +    guest_cpuinfo.pfr64.mpam = 0;
>> +    guest_cpuinfo.pfr64.mpam_frac = 0;
>> +
>> +    /* Disable SVE as Xen does not support it */
>> +    guest_cpuinfo.pfr64.sve = 0;
>> +    guest_cpuinfo.zfr64.bits[0] = 0;
>> +
>> +    /* Disable MTE as Xen does not support it */
>> +    guest_cpuinfo.pfr64.mte = 0;
>> +#endif
>> +
>> +    /* Disable AMU */
>> +#ifdef CONFIG_ARM_64
>> +    guest_cpuinfo.pfr64.amu = 0;
>> +#endif
>> +    guest_cpuinfo.pfr32.amu = 0;
>> +
>> +    /* Disable RAS as Xen does not support it */
>> +#ifdef CONFIG_ARM_64
>> +    guest_cpuinfo.pfr64.ras = 0;
>> +    guest_cpuinfo.pfr64.ras_frac = 0;
>> +#endif
>> +    guest_cpuinfo.pfr32.ras = 0;
>> +    guest_cpuinfo.pfr32.ras_frac = 0;
>> +
>> +    return 0;
>> +}
>> +/*
>> + * This function needs to be run after all smp are started to have
>> + * cpuinfo structures for all cores.
>> + */
>> +__initcall(create_guest_cpuinfo);
>> +
>> /*
>>  * Local variables:
>>  * mode: C
>> diff --git a/xen/include/asm-arm/cpufeature.h 
>> b/xen/include/asm-arm/cpufeature.h
>> index 64354c3f19..0ab6dd42a0 100644
>> --- a/xen/include/asm-arm/cpufeature.h
>> +++ b/xen/include/asm-arm/cpufeature.h
>> @@ -290,6 +290,8 @@ extern void identify_cpu(struct cpuinfo_arm *);
>> extern struct cpuinfo_arm cpu_data[];
>> #define current_cpu_data cpu_data[smp_processor_id()]
>> 
>> +extern struct cpuinfo_arm guest_cpuinfo;
>> +
>> #endif /* __ASSEMBLY__ */
>> 
>> #endif
>> -- 
>> 2.17.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.