Re: [PATCH V3 02/23] x86/ioreq: Add IOREQ_STATUS_* #define-s and update code for moving

[Oleksandr <olekstysh@xxxxxxxxx>]

On 07.12.20 13:19, Jan Beulich wrote:

Hi Jan

> On 30.11.2020 11:31, Oleksandr Tyshchenko wrote:
> > --- a/xen/include/asm-x86/hvm/ioreq.h
> > +++ b/xen/include/asm-x86/hvm/ioreq.h
> > @@ -74,6 +74,10 @@ unsigned int hvm_broadcast_ioreq(ioreq_t *p, bool buffered);
> >   
> >   void hvm_ioreq_init(struct domain *d);
> >   
> > +#define IOREQ_STATUS_HANDLED     X86EMUL_OKAY
> > +#define IOREQ_STATUS_UNHANDLED   X86EMUL_UNHANDLEABLE
> > +#define IOREQ_STATUS_RETRY       X86EMUL_RETRY
> This correlation may not be altered. I think a comment is needed
> to this effect, to avoid someone trying to subsequently fold the
> x86 and (to be introduced) Arm ones.
ok, will add.


> With that
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Thank you.


--
Regards,

Oleksandr Tyshchenko