Re: [PATCH v5 10/23] libxl: remove get_all_assigned_devices() from libxl_pci.c

[Wei Liu <wl@xxxxxxx>]

On Thu, Dec 03, 2020 at 02:25:21PM +0000, Paul Durrant wrote:
> From: Paul Durrant <pdurrant@xxxxxxxxxx>
> 
> Use of this function is a very inefficient way to check whether a device
> has already been assigned.
> 
> This patch adds code that saves the domain id in xenstore at the point of
> assignment, and removes it again when the device id de-assigned (or the
> domain is destroyed). It is then straightforward to check whether a device
> has been assigned by checking whether a device has a saved domain id.
> 
> NOTE: To facilitate the xenstore check it is necessary to move the
>       pci_info_xs_read() earlier in libxl_pci.c. To keep related functions
>       together, the rest of the pci_info_xs_XXX() functions are moved too.
> 
> Signed-off-by: Paul Durrant <pdurrant@xxxxxxxxxx>
> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>

Acked-by: Wei Liu <wl@xxxxxxx>