Re: [PATCH v2 06/17] xen/cpupool: use ERR_PTR() for returning error cause from cpupool_create()

[Jürgen Groß <jgross@xxxxxxxx>]

On 02.12.20 11:46, Jan Beulich wrote:
> On 02.12.2020 10:56, Jürgen Groß wrote:
> > On 02.12.20 09:58, Jan Beulich wrote:
> > > On 01.12.2020 09:21, Juergen Gross wrote:
> > > > Instead of a pointer to an error variable as parameter just use
> > > > ERR_PTR() to return the cause of an error in cpupool_create().
> > > >
> > > > This propagates to scheduler_alloc(), too.
> > > >
> > > > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> > > Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> > > with one small question:
> > >
> > > > --- a/xen/common/sched/core.c
> > > > +++ b/xen/common/sched/core.c
> > > > @@ -3233,26 +3233,25 @@ struct scheduler *scheduler_get_default(void)
> > > >        return &ops;
> > > >    }
> > > >    
> > > > -struct scheduler *scheduler_alloc(unsigned int sched_id, int *perr)
> > > > +struct scheduler *scheduler_alloc(unsigned int sched_id)
> > > >    {
> > > >        int i;
> > > > +    int ret;
> > > I guess you didn't merge this with i's declaration because of a
> > > plan/hope for i to be converted to unsigned int?
> > The main reason is I don't like overloading variables this way.
> That's no what I asked. I was wondering why the new decl wasn't
>
>      int i, ret;
Oh, then I completely misunderstood your question, sorry.

I had no special reason when writing the patch, but I think changing
i to be unsigned is a good idea. I'll do that in the next iteration.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: application/pgp-keys

Attachment: OpenPGP_signature
Description: OpenPGP digital signature