[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/iommu: vtd: Fix undefined behavior pci_vtd_quirks()


  • To: Julien Grall <julien@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Thu, 19 Nov 2020 16:41:36 +0000
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Julien Grall <jgrall@xxxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>
  • Delivery-date: Thu, 19 Nov 2020 16:42:00 +0000
  • Ironport-sdr: GQtfO1VChODKd5TOpknbO/rvyoyxzvPkOPnLVGARPnfQplQJqAjVlmVVG/TcPWYOovfeoqow3E lye7Vdes8VH+T10tQRS++uIWkPPZABAjBiWd4mY/t7jL4iiE5KXzJP5R/UzbcgcgiG9iE4+bJa n7qVb4GOjXvjXcc/Yvb7JeK4/NqqjbzOncd1Fwyk/IV+xaRnkCfTp+ul+2UzJ6T9GA634Zamzg yd3dvhTdeoeYMZ4HzgCBLQQawVsoSvMLsz1O0kmKb3cqkQFpBi3AkWmaCc3cV6WsB2n+eoEhDd 04I=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 19/11/2020 16:40, Julien Grall wrote:
>
>
> On 19/11/2020 16:38, Andrew Cooper wrote:
>> On 19/11/2020 14:52, Julien Grall wrote:
>>> Note that splat is from 4.11.4 and not staging. Although, the
>>> problem is
>>> still present.
>>>
>>> This can be solved by making the first operand unsigned int.
>>>
>>> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
>>>
>>> CR: https://code.amazon.com/reviews/CR-38873112
>>
>> IIRC, this is an internal link, which doesn't want including on the
>> upstream commit?
>
> Yes. I forgot to sanitize commit message when sending it.
>
> I will remove it while committing unless there is a need to send a new
> version.

No problem.  FWIW, Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.