[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/5] x86/p2m: split write_p2m_entry() hook
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 18 Nov 2020 10:31:48 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uh+DD3GMiZ41hDqyn5oTzk8Apb2C0EIQCg/syawI7YE=; b=N+Q5Bbi710y2VuNlM7JAhgtuI0tuHNR31SnacbvFvSnzgl1IOOI+tsY/Wol5HEgIE/s2xqHCncHACyYP0za1BA4SgdCbTmG7wWzJhgTeBrZesnRRdvHP5vhcvk4fEZx6addV9jh/94BbU8klzQahiNSbUKgDVsvTAKNUlJgYHtZvO+B3ZBgsssk+aFXd3lZFln9oFQ3QAfpDS94xHZy4RRpXAxayV8qjV4U5u/LN/vjsFM1546g+6+8B6830fOwfBMA5VkVTbIk5LNyqHCPD2ZQCS9mv6c3HyZtaoH0Wn0fA7ebIvdWIpoQZ5XPAswLCAMd1yM+PJ92eMaxjjSg/JA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I/K1kP/j2sUa1/fwfQP/s9wm0TnUhezZx0yQKmUh4xby6W/VQwyGXMkquX+3KTm311gnuJ6jyyk3Xx6AAh4AZVuB6w3fbES1GtSuZuOFq0YkNED+Wa7ZsYanljzYNvsalBHh7ty+TF4zIFzE+txHH4/6UN4VvLYfNV1kAde5tNNKFwyt/aQ/6VOfM9NaFytkEZV2zZ/zZtvs2jCgzzuxOQkw2KiCh+Sep8TRJV/ZN6W7siikYFt+OLSIWR+xK151hWUObL76fpO77Bv4MC74AskYa/wvs168YjVKskwAqRhd1TF99y4xKC+Yo/f2xwxdrja3J2IBqUF5Gp6soLTw7w==
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>
- Delivery-date: Wed, 18 Nov 2020 09:32:00 +0000
- Ironport-sdr: FRg8CvNcHdcJXOZczSlcz6tR7j7LJ8niMNJLZpqtJTHp+kaZuuyG8Jo2ZNhkRfeRPRJQdMVt/p zCwv+B82ydhBax8tTmZWNJ4WBEDfRh4E3fh1/WDOYNMg9A4B+bjQu7zzsxuYYXlRKGj/+TyDbJ CK1Ne84MJVdtsQdEfAkWGOxpKUtnzwn+xNOyLjbjECQilQnh/Rb0JxXCuvj8ZgLPLXBKHUZ8Hq jDJn27dt7GY9M5nfnsToGegHfI8WjW6cz5QwMk4PG5wvFKz+hMldgUD+ssAikBh/e+8iTokQPP 02o=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Oct 28, 2020 at 10:24:53AM +0100, Jan Beulich wrote:
> Fair parts of the present handlers are identical; in fact
> nestedp2m_write_p2m_entry() lacks a call to p2m_entry_modify(). Move
> common parts right into write_p2m_entry(), splitting the hooks into a
> "pre" one (needed just by shadow code) and a "post" one.
>
> For the common parts moved I think that the p2m_flush_nestedp2m() is,
> at least from an abstract perspective, also applicable in the shadow
> case. Hence it doesn't get a 3rd hook put in place.
>
> The initial comment that was in hap_write_p2m_entry() gets dropped: Its
> placement was bogus, and looking back the the commit introducing it
> (dd6de3ab9985 "Implement Nested-on-Nested") I can't see either what use
> of a p2m it was meant to be associated with.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks, Roger.
|
