[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/vpt: fix build with old gcc

To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Date: Wed, 11 Nov 2020 13:07:28 +0000
Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
Delivery-date: Wed, 11 Nov 2020 13:07:41 +0000
Ironport-sdr: XwCwG/3cCEY3R262RXsJvddRrMasfNx/uxqHcbSVReuFIPAVI1C5MQA1L1E7B/bgsyWKLHK+yZ KPaNhw0OM5AsyUdwk5bVmdr9rpmm9Rxk2Gxg/CJvZruHbH2pQieSNFI1JR/AtQJm1RHCpatT1J bCKDsVlhHRlCVkw1cdxksitAnL3OBITv0MO0itiTzxPAM7eWJIeYUEfIR+39u8BvmhiGXDV7Cg /bLJc3NNKM3pGXZgr17/BzY2polPTPbFFY4RiWL91ItqYDqeEpz6Tm8OTFHQiIRj0i+B5L4sRv 410=
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 11/11/2020 12:58, Jan Beulich wrote:
> I believe it was the XSA-336 fix (42fcdd42328f "x86/vpt: fix race when
> migrating timers between vCPUs") which has unmasked a bogus
> uninitialized variable warning. This is observable with gcc 4.3.4, but
> only on 4.13 and older; it's hidden on newer versions apparently due to
> the addition to _read_unlock() done by 12509bbeb9e3 ("rwlocks: call
> preempt_disable() when taking a rwlock").
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

References:
- [PATCH] x86/vpt: fix build with old gcc
  - From: Jan Beulich

Prev by Date: Re: [PATCH 04/24] sd: update the bdev size in sd_revalidate_disk
Next by Date: Re: [PATCH 05/24] block: remove the update_bdev parameter from set_capacity_revalidate_and_notify
Previous by thread: [PATCH] x86/vpt: fix build with old gcc
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.