Re: [PATCH V2 11/23] xen/ioreq: Move x86's io_completion/io_req fields to struct vcpu

[Oleksandr <olekstysh@xxxxxxxxx>]

On 11.11.20 10:04, Jan Beulich wrote:

Hi Jan

> On 15.10.2020 18:44, Oleksandr Tyshchenko wrote:
> > --- a/xen/include/xen/sched.h
> > +++ b/xen/include/xen/sched.h
> > @@ -143,6 +143,19 @@ void evtchn_destroy_final(struct domain *d); /* from 
> > complete_domain_destroy */
> >   
> >   struct waitqueue_vcpu;
> >   
> > +enum io_completion {
> > +    IO_no_completion,
> > +    IO_mmio_completion,
> > +    IO_pio_completion,
> > +    IO_realmode_completion
> > +};
> May I suggest wrapping at least the last one in #ifdef CONFIG_X86?
>
> Also please add a trailing comma.
Yes, will do.


--
Regards,

Oleksandr Tyshchenko