Re: [PATCH V2 08/23] xen/ioreq: Introduce ioreq_params to abstract accesses to arch.hvm.params

[Oleksandr <olekstysh@xxxxxxxxx>]

On 20.10.20 13:41, Paul Durrant wrote:

Hi Paul

Sorry for the late response.


> > -----Original Message-----
> > From: Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>
> > Sent: 15 October 2020 17:44
> > To: xen-devel@xxxxxxxxxxxxxxxxxxxx
> > Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>; Paul Durrant 
> > <paul@xxxxxxx>; Jan Beulich
> > <jbeulich@xxxxxxxx>; Andrew Cooper <andrew.cooper3@xxxxxxxxxx>; Roger Pau Monné
> > <roger.pau@xxxxxxxxxx>; Wei Liu <wl@xxxxxxx>; Julien Grall <julien@xxxxxxx>; 
> > Stefano Stabellini
> > <sstabellini@xxxxxxxxxx>; Julien Grall <julien.grall@xxxxxxx>
> > Subject: [PATCH V2 08/23] xen/ioreq: Introduce ioreq_params to abstract 
> > accesses to arch.hvm.params
> >
> > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> >
> > We don't want to move HVM params field out of *arch.hvm* in this particular
> > case as although it stores a few IOREQ params, it is not a (completely)
> > IOREQ stuff and is specific to the architecture. Instead, abstract
> > accesses by the proposed macro.
> >
> > This is a follow up action to reduce layering violation in the common code.
> >
> > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> > CC: Julien Grall <julien.grall@xxxxxxx>
> Keeping the 'legacy' magic page code under an x86 ioreq.c would avoid the need 
> for this patch.
In that case, yes, agree.


--
Regards,

Oleksandr Tyshchenko