[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] docs: fix documentation to notice credit2 is the default


  • To: Jürgen Groß <jgross@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Tue, 10 Nov 2020 13:49:00 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PJW52Z4umjhNmHjsR3iz/CLYwuqpkZqVSsMAAX9G8sg=; b=k4gAVCrln5TMyoQa9H0P9npKDbShjAEVU0XuLNNCCleV+ciqNwmgVv09mQTMJyQbh6FJM/1wwrj6XALfkB8TTuugv0fzCStbZL+lEpICXhDz910n4UeOg6XGq33sbaZRoxejd0TR5HWsnzmu5/AlFA3Q4t7ddgS2S1AHh+q8tTSwbXw10yIWOJLGZeDFM5xT9kxeUio803xSxAkmlmF/L7So4MPWD94aFRFM7yxOHBTk2JKoCiDVCq7BMZ/mo8Cp2lDqQHWwRd7AHGU5Wr9wXcCQL8l1EmyBGQKlw9GL5GK+1Av6xjgDcZnJhbHufxNtCaKOdXIrD6JG4vLbg67uWw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O9PsT0qrAliX4oNyvxLOIAvYYqlcYse8YzvnYOANOkXe4qmYvQxArVdxINXx0NcMuHY1yAVO3BgJNnmDDJcpXaNYfDo0w8fIsCe8T9W2W1X44G4VGLFabkz8hF/t0SEdn35wqveSXnWKMmPgtbBqr4AE3KCTtttgbcnWWGpOBbYDKPqfw8hTVnlkMsOTYKISDRTHbSQ1cwzWgGTiumNqJ9MEhoERn7z5LfnCWM01FXuTCDcmUSUMXmKGgTqs7XL6zbbEmeb0/7NH+9hynlrdO/dKlSVrkn9Pf05UajUU8UvGAMZN+6ZVELm5kRzJl3vz7mbNpBpHLGM8rDXVtWe/FA==
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, "Ian Jackson" <iwj@xxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Tue, 10 Nov 2020 12:49:16 +0000
  • Ironport-sdr: SIu95eLLXhVgsoRszmQdX7MT47r5+U5X9aQO1+sOVkGDgw905QyQCpCjtusg0CL8i77Lf75twL 8De/Y6rK4fg3OMOhbWhq8pZ3zL+8JPEXtucOcJw3+PWI9a2OijBw/hyuzCPs8LCzA/GvFAj7BV /9SNxP/cFzqM/Jww1DbhDyGz7dkyJxruZnsAtpZoD15qIx/aYSi9Rk/4Jphz8/BKSDeimgF/DY k4BkObu1L/1T5Wc415GUTAJEiIVhBnnK27E+Hs8Vt5vFEckiP3jrCWXl30hWQiOQytyERfxJXF Q44=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Nov 10, 2020 at 12:31:14PM +0100, Jürgen Groß wrote:
> On 10.11.20 12:21, Roger Pau Monne wrote:
> > Fix the command line document to account for credit2 now being the
> > default scheduler.
> > 
> > Fixes: dafd936dddbd ('Make credit2 the default scheduler')
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > ---
> >   docs/misc/xen-command-line.pandoc | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/docs/misc/xen-command-line.pandoc 
> > b/docs/misc/xen-command-line.pandoc
> > index 4ae9391fcd..789aead148 100644
> > --- a/docs/misc/xen-command-line.pandoc
> > +++ b/docs/misc/xen-command-line.pandoc
> > @@ -1876,7 +1876,7 @@ with read and write permissions.
> >   ### sched
> >   > `= credit | credit2 | arinc653 | rtds | null`
> > -> Default: `sched=credit`
> > +> Default: `sched=credit2`
> >   Choose the default scheduler.
> > 
> 
> Tried that before:
> 
> https://lists.xen.org/archives/html/xen-devel/2019-01/msg01097.html
> 
> And Andrew didn't like it...

One way or another we need to get this fixed in the document. Listing
credit as the still the default is wrong.

I think there are several places in xen-command-line.pandoc that just
contain the default values set in Kconfig, so IMO if we want to
change this it should be done wholesale rather than picking on every
default value change. Opinions?

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.