[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 09/36] qdev: Make qdev_get_prop_ptr() get Object* arg





On Fri, Oct 30, 2020 at 11:29 AM Marc-André Lureau <marcandre.lureau@xxxxxxxxx> wrote:


On Fri, Oct 30, 2020 at 2:07 AM Eduardo Habkost <ehabkost@xxxxxxxxxx> wrote:
Make the code more generic and not specific to TYPE_DEVICE.

Signed-off-by: Eduardo Habkost <ehabkost@xxxxxxxxxx>

Nice cleanup!, but fails to build atm

../hw/block/xen-block.c:403:9: error: ‘dev’ undeclared (first use in this function); did you mean ‘vdev’?
  403 |     if (dev->realized) {


That seems to be the only issue though, so with that fixed:
Reviewed-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>

--
Marc-André Lureau

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.