[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] [v2] x86: apic: avoid -Wshadow warning in header
- To: 'Arnd Bergmann' <arnd@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>
- From: David Laight <David.Laight@xxxxxxxxxx>
- Date: Thu, 29 Oct 2020 16:30:19 +0000
- Accept-language: en-GB, en-US
- Authentication-results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@xxxxxxxxxx
- Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, the arch/x86 maintainers <x86@xxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, "K. Y. Srinivasan" <kys@xxxxxxxxxxxxx>, Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>, Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx>, Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>, "Wanpeng Li" <wanpengli@xxxxxxxxxxx>, Jim Mattson <jmattson@xxxxxxxxxx>, Joerg Roedel <joro@xxxxxxxxxx>, "linux-hyperv@xxxxxxxxxxxxxxx" <linux-hyperv@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, kvm list <kvm@xxxxxxxxxxxxxxx>, "Platform Driver" <platform-driver-x86@xxxxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "open list:IOMMU DRIVERS" <iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 29 Oct 2020 16:30:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHWrdqfIpyThHXm90WmqPrnIVTaQ6muxUWQ
- Thread-topic: [PATCH] [v2] x86: apic: avoid -Wshadow warning in header
From: Arnd Bergmann
> Sent: 29 October 2020 09:51
...
> I think ideally there would be no global variable, withall accesses
> encapsulated in function calls, possibly using static_call() optimizations
> if any of them are performance critical.
There isn't really a massive difference between global variables
and global access functions.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT,
UK
Registration No: 1397386 (Wales)
|
